Page MenuHomePhabricator

Provide an option to cancel keep or clear reading list articles on device when logging out [needed for user test]
Closed, ResolvedPublic1 Estimated Story Points

Description

NOTE: Per usertesting results in T186273, revise verbiage of the dialog to “Keep saved articles on device” to more clearly refer to leaving reading lists on the app when logging out
This task is the inverse to T180236
Scenario

When a user who is opted-in to sync reading lists logs OUT, provide an option for them to keep or delete articles locally.

Proposed solution

When a user who is opted-in to sync logs OUT, provide an option for them to keep or delete locally saved articles

Dialog element(Draft) Text
TitleKeep saved articles on device? Keep saved articles in the app?
TextThere are articles synced to your Wikipedia account. Would you like to keep them on this device after you log out? There are articles currently saved in reading lists. Would you like to keep them there after logging out?
'Yes' keep action textYes, keep articles on deviceYes, keep articles in lists
'No' remove action textNo, delete articles from device No, delete articles from lists

Reading list sync - keep or delete on Log OUT.png (1×720 px, 106 KB)

QA required ?

QA steps

Pre-requisites: User is logged in, has opted-in to syncing reading lists, and has articles saved into reading lists

  1. Open the app and navigate to the My lists screen, noting the reading lists that are saved.
  2. Log out. It is expected that a message will be shown (see above mock) asking if the user wishes to keep or remove the reading list articles from the device.
  3. It is expected that if the "No" option is selected, all reading list items will be deleted. If however, the "Yes" option is selected, the lists should remain the same upon logging out.
  4. If "no" is selected in the previous step, it is expected that logging in again to the same device with the same account will re-sync the saved lists that appeared in step 1.

Event Timeline

Charlotte renamed this task from Provide an option to cancel keep or clear reading list articles on device when logging out to Provide an option to cancel keep or clear reading list articles on device when logging out - S.Jan 2 2018, 6:10 PM
Charlotte triaged this task as Medium priority.
Charlotte renamed this task from Provide an option to cancel keep or clear reading list articles on device when logging out - S to Provide an option to cancel keep or clear reading list articles on device when logging out.Jan 3 2018, 4:43 PM
Charlotte set the point value for this task to 1.

Change 402444 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Shows an option dialog when logging out

https://gerrit.wikimedia.org/r/402444

Change 399468 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Sync Reading Lists behavior dialogs

https://gerrit.wikimedia.org/r/399468

Change 402444 abandoned by Cooltey:
Shows an option dialog when logging out

Reason:
Combine to the other patch

https://gerrit.wikimedia.org/r/402444

Charlotte renamed this task from Provide an option to cancel keep or clear reading list articles on device when logging out to Provide an option to cancel keep or clear reading list articles on device when logging out [needed for user test].Feb 12 2018, 4:21 PM

Change 399468 merged by jenkins-bot:
[apps/android/wikipedia@master] Sync Reading Lists behavior dialogs

https://gerrit.wikimedia.org/r/399468

Works on Wikipedia v2.7.255-alpha-2018-02-16 on Nexus 5 (6.0.1)

RHo added a subscriber: Charlotte.

hey @Charlotte - moved to blocked to wait for revised verbiage

@RHo @Dbrant Let's try this. The verbiage now closely matches the other dialog, and removes some of the ambiguity around the use of the word "sync" because of course the articles won't be synced any more after the user logs out.

Dialog element(Draft) Text
TitleKeep saved articles on device?
TextThere are articles currently saved to the reading list. Would you like to keep them on this device after you log out?
'Yes' keep action textYes, keep articles on device
'No' remove action textNo, delete articles from device

Hi @Charlotte, @Dbrant - can we move this to a copy doc for easier editing? I think there are a couple of points that I hadn't clearly articulated from user feedback.
https://docs.google.com/document/d/1ItQnzgCvJbgrj3cEe2iMZHiDFq1TehDc-mMN8Mo0dCo/edit#

@RHo @Dbrant Let's try this. The verbiage now closely matches the other dialog, and removes some of the ambiguity around the use of the word "sync" because of course the articles won't be synced any more after the user logs out.

Dialog element(Draft) Text
TitleKeep saved articles on device?
TextThere are articles currently saved to the reading list. Would you like to keep them on this device after you log out?
'Yes' keep action textYes, keep articles on device
'No' remove action textNo, delete articles from device

Change 415298 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Rejigger order of certain settings, and finalize verbiage.

https://gerrit.wikimedia.org/r/415298

Change 415298 merged by jenkins-bot:
[apps/android/wikipedia@master] Rejigger order of certain settings, and finalize verbiage.

https://gerrit.wikimedia.org/r/415298

RHo removed a subscriber: gerritbot.

LGTM on Nexus 5, testing v2.7.225-alpha-2018-03-02

image.png (1×1 px, 184 KB)