Maniphest T183634

MCR Revision::getRevisionText no longer uses the $wiki parameter
Closed, ResolvedPublic
Actions

Description

With the MCR Revision overhaul getRevisionText no longer does anything with the $wiki parameter.

With all of our code on Gerrit this is only called with a $wiki param in:

core/tests/phpunit/includes/RevisionTest.php RevisionTest::testGetRevisionText (but this test doesn't have a test case with $wiki)
extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php WikiPageEntityRevisionLookup::loadEntityBlob (the method causing both T183631 and T183583)

Previous behaviour should be restored.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+205 -28	[MCR] Introduce BlobStoreFactory

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T183583 en.wikipedia.beta RevisionBasedEntityLookup.php: Failed to unserialize the content object on multiple pages
		Resolved		Addshore	T183631 refreshLinksPrioritized job failing on beta - EntityLookupException: Failed to unserialize the content object.
		Resolved		Addshore	T183634 MCR Revision::getRevisionText no longer uses the $wiki parameter

Event Timeline

Addshore triaged this task as Unbreak Now! priority.Dec 23 2017, 4:27 PM

Addshore created this task.

Addshore added a parent task: T183631: refreshLinksPrioritized job failing on beta - EntityLookupException: Failed to unserialize the content object..

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Dec 23 2017, 5:37 PM

Change 399996 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Introduce BlobStoreFactory

https://gerrit.wikimedia.org/r/399996

Addshore closed this task as Resolved.Dec 26 2017, 7:55 PM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Dec 28 2017, 1:28 PM

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Jan 2 2018, 6:54 PM

CCicalese_WMF moved this task from Inbox to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:55 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 5:07 PM