language icon appears in Wikidata on mobile web, but doesn't do anything
Closed, ResolvedPublic
Actions

Description

The language icon (文A) appears in Wikidata and Mediawiki on mobile web (such as https://m.wikidata.org/ and https://m.mediawiki.org/ ; the mobile view uses the Minerva skin), but doesn't do anything useful.

It could do useful things, for example switch the language is UI, labels, etc., or to move to the article in the projects according to sitelinks.

Since it is unusable, it should be disabled for the time being

Acceptance criteria

Update mediawiki-config so that MinervaAlwaysShowLanguageButton defaults to true for all wikis except mediawikiwiki and wikidatawiki where it should be false
Once you have been given the green light, schedule deployment of the change. Be sure to read up on https://wikitech.wikimedia.org/wiki/X-Wikimedia-Debug beforehand to check how you can test your change during that deploy window. @Jdlrobson can assist!

Details

	Subject	Repo	Branch	Lines +/-
	Remove language button from Wikidata and MediaWiki	operations/mediawiki-config	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned Here: T106361: List of translations from <languages> tag is not mobile-friendly

Event Timeline

Amire80 created this task.Dec 24 2017, 4:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 24 2017, 4:47 PM

Amire80 added a project: I18n.Dec 24 2017, 4:47 PM

Liuxinyu970226 subscribed.Dec 25 2017, 1:33 AM

@Amire80 Please, can you add more description to this task so that it can be taken to the code-In site? Thanks.

I'm really not sure that it's appropriate for code-in. It's not a simple bug fix, but a question of design and defining the most desirable functionality.

Jdlrobson edited projects, added MinervaNeue, Web-Team-Backlog; removed MobileFrontend.Jan 2 2018, 10:57 PM

Jdlrobson updated the task description. (Show Details)

This should actually be a simple bug fix - we have the configuration option MinervaAlwaysShowLanguageButton which should be false for Wikidata (and MediaWiki) - not sure what happened there. We're also showing it on MediaWiki.org which makes no sense.

Have added the Google-Code-In tag, otherwise someone else should feel free to go ahead and make this happen.

(note we have absolutely no bandwidth to redesign this button for these two wikis - but see T106361 for MediaWiki.org example)

Jdlrobson added a project: Web-Team-Backlog.Jan 2 2018, 11:03 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jan 3 2018, 6:15 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jan 3 2018, 11:07 PM

Aklapper updated the task description. (Show Details)Jan 5 2018, 12:45 PM

Published as https://codein.withgoogle.com/tasks/4942367410880512/

Change 402643 had a related patch set uploaded (by Albert221; owner: Albert221):
[operations/mediawiki-config@master] Remove language button from Wikidata and MediaWiki

https://gerrit.wikimedia.org/r/402643

gerritbot added a project: Patch-For-Review.Jan 7 2018, 10:26 PM

Albert221 claimed this task.Jan 7 2018, 11:06 PM

Change 402643 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove language button from Wikidata and MediaWiki

https://gerrit.wikimedia.org/r/402643

Mentioned in SAL (#wikimedia-operations) [2018-01-08T19:22:26Z] <thcipriani@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:402643|Remove language button from Wikidata and MediaWiki]] T183665 (duration: 00m 51s)

Albert221 closed this task as Resolved.Jan 8 2018, 7:31 PM

Liuxinyu970226 unsubscribed.Jan 9 2018, 11:23 AM

• Phabricator_maintenance moved this task from Triaged but Future to 2017-18 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:43 AM

language icon appears in Wikidata on mobile web, but doesn't do anythingClosed, ResolvedPublicActions