Image border missing in Timeless skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Od1n
	Dec 27 2017, 12:28 PM

Description

Images using the code [[File:Flag of Japan.svg|30px|border]] are expected to have a 1px grey border.
But this border is missing in the Timeless skin.

Demo: https://en.wikipedia.org/w/index.php?title=Draft:Sandbox&oldid=817291472&useskin=timeless
Expected: https://en.wikipedia.org/w/index.php?title=Draft:Sandbox&oldid=817291472&useskin=vector

Indeed, it is missing the following rule from mediawiki.skinning/content.css (module mediawiki.skinning.interface):

img.thumbborder {
	border: 1px solid #eaecf0;
}

Details

	Subject	Repo	Branch	Lines +/-
	Add missing border on plain pictures with border option	mediawiki/skins/Timeless	master	+2 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T199348: Show image border if border parameter is specified
T175889: Support image border in Timeless

Event Timeline

Od1n created this task.Dec 27 2017, 12:28 PM

@Od1n I will be adding this task on google code-in site :)

@Eugene233: Would you mentor this in Google-Code-in-2017 or why was the tag added? :)

Yes @Od1n I wish to mentor this task

Od1n updated the task description. (Show Details)Dec 27 2017, 3:13 PM

Thanks. Published as https://codein.withgoogle.com/tasks/6332632772116480/

I just noticed this border's color is varying across the skins…

Vector and Monobook: #eaecf0
Modern: #ddd
Cologneblue: #ddd
Minerva: #c8ccd1

I tried to determine the proper color for Timeless, without success.

@Od1n: Use the @grey-bright variable.

Thanks :) @grey-bright variable is #eee. It's a bit too light in my opinion. The next one, @grey, is #ccc, which in turn is a bit too dark. Something between the two would have been optimal.

This being said, I'd bend for @grey because we need the contrast, and it is the value used for other borders. Also note it is closer to the Minerva skin's value.

@grey-bright is what is used for image borders in thumbs. It should be the same. Whether or not the value is too light in general is a separate issue; you are welcome to file a task about that as well.

ashley merged a task: T175889: Support image border in Timeless.Dec 31 2017, 10:53 AM

ashley added a subscriber: Zebulon84.

SamanthaNguyen moved this task from Backlog to Bugs on the Timeless board.Jan 2 2018, 10:05 PM

Any news on this?

I made the patch, but the Gerrit Patch Uploader currently fails to submit it (and there is no error message).

Gerrit is a PITA to use without this tool, so for now I'll just post the patch below. If someone wants to submit it right now, please do :)

(summary: Add missing border on plain pictures with border option)

--- a/resources/screen-common.less
+++ b/resources/screen-common.less
@@ -425,7 +425,8 @@
 	font-size: 95%;
 	padding: 0.5em 1em;
 }
-.thumbinner .thumbimage {
+.thumbinner .thumbimage,
+.thumbborder {
 	border: solid 1px @grey-bright;
 }
 #mw-content li.gallerybox div.thumb {

Izno merged a task: T199348: Show image border if border parameter is specified.Jul 11 2018, 5:49 PM

Izno added a subscriber: Jc86035.

Change 447037 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Jean-Yves Le Gallou):
[mediawiki/skins/Timeless@master] Add missing border on plain pictures with border option

https://gerrit.wikimedia.org/r/447037

gerritbot added a project: Patch-For-Review.Jul 20 2018, 7:47 AM

Change 447037 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Add missing border on plain pictures with border option

https://gerrit.wikimedia.org/r/447037

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 21 2018, 2:00 PM

Isarra closed this task as Resolved.Aug 30 2018, 2:26 AM

Isarra claimed this task.