Create pop-up for scores showing more features
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ebe123
	Dec 28 2017, 9:06 AM

Description

Currently, when writing musical scores in MediaWiki, there is an attribute midi that has to be set to have the respective MIDI file displayed. It is accessible by clicking on the score. The decision on whether or not to include MIDI is arbitrary, and is the subject of discussion in the parent task. What would be more intuitive would be a pop-up that includes information about the score (such as its code) with a link to download MIDI (wouldn't be an attribute to set).

This task would be modifying rESCR extension-Score. Basic knowledge of HTML/CSS/JS suffices for this task; not requiring knowledge of score engraving. Patch submission through Gerrit is required, and should take a couple (2-3) days to complete, from design to patch submission.

Beginner: No (don't think so at least)
Instance Count: 1
Category: Code
Tags: HTML, JS/CSS, PHP

I would be available through email (beauleetienne0@gmail.com) or by IRC (Ebe123 or itajara) as a mentor.

Details

Subject	Repo	Branch	Lines +/-
Remove midi checkbox from VisualEditor	mediawiki/extensions/Score	master	+6 -45
Add source DL link to popup, fix $needMidi cond	mediawiki/extensions/Score	master	+69 -17
Add popup showing midi DL link on score click	mediawiki/extensions/Score	master	+155 -17

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		Ebe123	T114757 Remove "midi" option
		Resolved		Albert221	T183736 Create pop-up for scores showing more features

Event Timeline

I don't know if this would be admissible as a little project, but here's an idea.

@Ebe123: Thanks a lot! I've sent an invitation email to register as a Google-Code-in-2017 mentor. Could you also add yourself to the list of mentors? Thanks!

https://codein.withgoogle.com/dashboard/tasks/4771869758586880/

Ebe123 moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Dec 28 2017, 8:33 PM

Albert221 claimed this task.Dec 28 2017, 9:32 PM

Change 400834 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/extensions/Score@master] Add popup with score stuff

https://gerrit.wikimedia.org/r/400834

gerritbot added a project: Patch-For-Review.Dec 30 2017, 12:58 AM

mb subscribed.Dec 30 2017, 6:37 AM

Change 400834 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Add popup showing midi DL link on score click

https://gerrit.wikimedia.org/r/400834

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 30 2017, 8:00 PM

Change 401093 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/extensions/Score@master] Add source DL link to popup

https://gerrit.wikimedia.org/r/401093

Change 401093 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Add source DL link to popup, fix $needMidi cond

https://gerrit.wikimedia.org/r/401093

Albert221 closed this task as Resolved.Dec 31 2017, 12:12 AM

Krinkle mentioned this in T114757: Remove "midi" option.Dec 31 2017, 12:37 AM

Change 402131 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/extensions/Score@master] Remove midi checkbox from VisualEditor

https://gerrit.wikimedia.org/r/402131

Change 402131 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Remove midi checkbox from VisualEditor

https://gerrit.wikimedia.org/r/402131

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 5 2018, 12:01 AM

Skierpage mentioned this in T308953: Can't download MIDI of generated score on mobile.May 21 2022, 8:37 PM

Maintenance_bot removed a project: Patch-For-Review.May 21 2022, 9:30 PM