Page MenuHomePhabricator

Newsletters with non-main-namespace main pages don't work correctly
Closed, ResolvedPublic

Description

  1. Create a newsletter that has a main page that is not located in mainspace.
  2. Attempt to edit it via the api to add/or remove publishers or do an unrelated change. Expected result: the change gets through. Actual result: It fails with error code "hookaborted"
  3. Attempt to edit it via the manage button or action=edit. Expected result: gets through, creating a revision in the history as expected. Actual result: gets through to the db, without making any changes to the page content.

Event Timeline

Pppery created this task.Dec 28 2017, 3:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 28 2017, 3:16 PM

Change 400589 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Allow newsletters to have non-mainspace main pages

https://gerrit.wikimedia.org/r/400589

Pppery renamed this task from Newsletters with non-main-namespace pages don't work correctly to Newsletters with non-main-namespace main pages don't work correctly.Dec 28 2017, 5:07 PM

Change 400589 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Allow newsletters to have non-mainspace main pages

https://gerrit.wikimedia.org/r/400589

Change 401114 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix bug that causes newsletter names in database to contain namespace name

https://gerrit.wikimedia.org/r/401114

Change 401114 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Fix bug that causes newsletter names in database to contain namespace name

https://gerrit.wikimedia.org/r/401114

Pppery closed this task as Resolved.Dec 31 2017, 3:44 PM
Pppery claimed this task.
Pppery removed a project: Patch-For-Review.