Page MenuHomePhabricator
Create Task
Maniphest T183759

MediaWiki::shell with parameter fails on Windows
Closed, ResolvedPublic
Actions

Description

Executing Shell::command( $wgScoreLilyPond, '--version' ) returns score-versionerr with the message:

'c:\LilyPond\usr\bin\lilypond.exe" "--version' is not recognized as an internal or external command, operable program, or batch file.

Notably, the quotation marks are quite odd in the error message. This works under Vagrant though. It only fails on Windows. Extending the issue, this probably also affects the rendering stage.

Details

ProjectBranchLines +/-Subject
mediawiki/coreREL1_31+163 -59Fixes shell edge-cases in Windows
mediawiki/coreREL1_34+161 -61Fixes shell edge-cases in Windows
mediawiki/coreREL1_35+161 -61Fixes shell edge-cases in Windows
mediawiki/coremaster+161 -61Fixes shell edge-cases in Windows
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ebe123 created this task.Dec 28 2017, 11:14 PM
Ebe123 triaged this task as High priority.Dec 28 2017, 11:19 PM

Shell::command( $wgScoreLilyPond . '--version' ) works (notice concatenation instead of parametration) on Windows.

Ebe123 added a subscriber: Legoktm.Dec 29 2017, 2:10 AM
MaxSem added a subscriber: MaxSem.Feb 26 2018, 9:36 PM
Daimona merged a task: T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).Jul 19 2018, 9:37 AM
Daimona added subscribers: Glanthor_Reviol, Daimona.
Daimona added a project: SyntaxHighlight.Jul 20 2018, 4:11 PM

Affected as well.

Daimona mentioned this in T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).Aug 16 2018, 4:45 PM
Daimona mentioned this in T204475: update.php ends without messages after MCR migration when using WinCache.Sep 21 2018, 11:42 AM
osorio-juan-microsoft claimed this task.Oct 24 2018, 4:21 PM
osorio-juan-microsoft added a comment.Oct 24 2018, 4:29 PM

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

Reedy added a comment.Oct 24 2018, 4:31 PM
In T183759#4692071, @osorio-juan-microsoft wrote:

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

On gerrit, yes

gerritbot added a subscriber: gerritbot.Nov 6 2018, 12:41 AM

Change 471885 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

gerritbot added a project: Patch-For-Review.Nov 6 2018, 12:41 AM
Reedy mentioned this in T208841: git-changed-in-head breaks with paths with spaces in.Nov 6 2018, 11:20 AM
Krenair added a subscriber: Krenair.Nov 9 2018, 6:25 PM
Ebe123 merged a task: T221776: Score Extension can't run on MediaWiki for Windows due to lilypond.exe not recognized.Apr 24 2019, 5:14 PM
Ebe123 added a subscriber: dzeaman.
gerritbot added a comment.May 20 2019, 11:11 AM

Change 471885 had a related patch set uploaded (by TheDJ; owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

Reedy added a subtask: T223903: php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so.Dec 17 2019, 3:59 PM
Reedy added a project: Platform Engineering.
Reedy added a comment.Dec 17 2019, 4:32 PM

While T223903 is breaking one of the tests, it seems a few other tests are (still) erroring

Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Dec 18 2019, 4:48 PM
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Dec 18 2019, 8:30 PM
WDoranWMF moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:41 PM
gerritbot added a comment.Aug 27 2020, 11:02 AM

Change 471885 merged by jenkins-bot:
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

gerritbot added a comment.Aug 27 2020, 11:07 AM

Change 622769 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_35] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622769

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 27 2020, 12:00 PM
gerritbot added a comment.Aug 27 2020, 12:33 PM

Change 622769 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622769

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 27 2020, 1:00 PM
gerritbot added a comment.Aug 29 2020, 6:12 PM

Change 622784 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_34] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622784

gerritbot added a comment.Aug 29 2020, 6:33 PM

Change 623125 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_31] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/623125

gerritbot added a comment.Aug 29 2020, 6:44 PM

Change 622784 merged by jenkins-bot:
[mediawiki/core@REL1_34] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622784

ReleaseTaggerBot added a project: MW-1.34-notes.Aug 29 2020, 7:00 PM
Reedy closed this task as Resolved.Aug 29 2020, 7:02 PM
gerritbot added a comment.Aug 29 2020, 7:08 PM

Change 623125 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/623125

ReleaseTaggerBot added a project: MW-1.31-release-notes.Aug 29 2020, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL