Page MenuHomePhabricator

MediaWiki::shell with parameter fails on Windows
Closed, ResolvedPublic

Description

Executing Shell::command( $wgScoreLilyPond, '--version' ) returns score-versionerr with the message:

'c:\LilyPond\usr\bin\lilypond.exe" "--version' is not recognized as an internal or external command, operable program, or batch file.

Notably, the quotation marks are quite odd in the error message. This works under Vagrant though. It only fails on Windows. Extending the issue, this probably also affects the rendering stage.

Event Timeline

Ebe123 triaged this task as High priority.Dec 28 2017, 11:19 PM

Shell::command( $wgScoreLilyPond . '--version' ) works (notice concatenation instead of parametration) on Windows.

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

On gerrit, yes

Change 471885 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

Change 471885 had a related patch set uploaded (by TheDJ; owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

While T223903 is breaking one of the tests, it seems a few other tests are (still) erroring

Change 471885 merged by jenkins-bot:
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

Change 622769 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_35] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622769

Change 622769 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622769

Change 622784 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_34] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622784

Change 623125 had a related patch set uploaded (by Reedy; owner: Juan Osorio (Microsoft)):
[mediawiki/core@REL1_31] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/623125

Change 622784 merged by jenkins-bot:
[mediawiki/core@REL1_34] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/622784

Change 623125 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/623125