MediaWiki::shell with parameter fails on Windows
Open, HighPublic
Actions

Description

Executing Shell::command( $wgScoreLilyPond, '--version' ) returns score-versionerr with the message:

'c:\LilyPond\usr\bin\lilypond.exe" "--version' is not recognized as an internal or external command, operable program, or batch file.

Notably, the quotation marks are quite odd in the error message. This works under Vagrant though. It only fails on Windows. Extending the issue, this probably also affects the rendering stage.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+140 -60	Fixes shell edge-cases in Windows

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		osorio-juan-microsoft	T183759 MediaWiki::shell with parameter fails on Windows
		Open		None	T223903 php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so

Event Timeline

Ebe123 created this task.Dec 28 2017, 11:14 PM

Shell::command( $wgScoreLilyPond . '--version' ) works (notice concatenation instead of parametration) on Windows.

Ebe123 added a subscriber: Legoktm.Dec 29 2017, 2:10 AM

MaxSem added a subscriber: MaxSem.Feb 26 2018, 9:36 PM

Daimona merged a task: T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).Jul 19 2018, 9:37 AM

Daimona added subscribers: Glanthor_Reviol, Daimona.

Affected as well.

Daimona mentioned this in T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).Aug 16 2018, 4:45 PM

Daimona mentioned this in T204475: update.php ends without messages after MCR migration when using WinCache.Sep 21 2018, 11:42 AM

osorio-juan-microsoft claimed this task.Oct 24 2018, 4:21 PM

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

In T183759#4692071, @osorio-juan-microsoft wrote:

I have an easy fix for this issue in particular (does not fix the other shell issue related to non-blocking pipes in Windows). Should I send a PR against master for mediawiki/core repo?

On gerrit, yes

Change 471885 had a related patch set uploaded (by Juan Osorio (Microsoft); owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

gerritbot added a project: Patch-For-Review.Nov 6 2018, 12:41 AM

Reedy mentioned this in T208841: git-changed-in-head breaks with paths with spaces in.Nov 6 2018, 11:20 AM

Krenair added a subscriber: Krenair.Nov 9 2018, 6:25 PM

Ebe123 merged a task: T221776: Score Extension can't run on MediaWiki for Windows due to lilypond.exe not recognized.Apr 24 2019, 5:14 PM

Ebe123 added a subscriber: dzeaman.

Change 471885 had a related patch set uploaded (by TheDJ; owner: Juan Osorio (Microsoft)):
[mediawiki/core@master] Fixes shell edge-cases in Windows

https://gerrit.wikimedia.org/r/471885

Reedy added a subtask: T223903: php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so.Dec 17 2019, 3:59 PM

Reedy added a project: Platform Engineering.

While T223903 is breaking one of the tests, it seems a few other tests are (still) erroring

Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Dec 18 2019, 4:48 PM