Page MenuHomePhabricator
Create Task
Maniphest T183798

Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages
Closed, DeclinedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/400998/ moves includes/Storage to includes/storage, and similar in tests/phpunit

These seemingly cause some user tests to fail, this shouldn't happen...

03:35:54 There were 6 failures:
03:35:54 
03:35:54 1) UserTest::testAutoblockCookies
03:35:54 Autoblock does not work
03:35:54 Failed asserting that false matches expected true.
03:35:54 
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:653
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:54 
03:35:54 2) UserTest::testAutoblockCookiesDisabled
03:35:54 Failed to insert block
03:35:54 Failed asserting that false is true.
03:35:54 
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:700
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:54 
03:35:54 3) UserTest::testAutoblockCookieInfiniteExpiry
03:35:54 Failed to insert block
03:35:54 Failed asserting that false is true.
03:35:54 
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:745
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:54 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:54 
03:35:54 4) UserTest::testSoftBlockRanges
03:35:54 Failed asserting that Block Object &0000000000000000feaa6a4d093f5654 (
03:35:54     'mReason' => ''
03:35:54     'mTimestamp' => '20171230033531'
03:35:54     'mAuto' => '0'
03:35:54     'mExpiry' => '20171230083531'
03:35:54     'mHideName' => '0'
03:35:54     'mParentBlockId' => null
03:35:54     'mId' => 33
03:35:55     'mFromMaster' => false
03:35:55     'mBlockEmail' => '0'
03:35:55     'mDisableUsertalk' => true
03:35:55     'mCreateAccount' => '0'
03:35:55     'target' => User Object &0000000000000000feaa6a4d0937e414 (
03:35:55         'mId' => null
03:35:55         'mName' => 'TestUser 8f4931.003'
03:35:55         'mRealName' => null
03:35:55         'mEmail' => null
03:35:55         'mTouched' => null
03:35:55         'mQuickTouched' => null
03:35:55         'mToken' => null
03:35:55         'mEmailAuthenticated' => null
03:35:55         'mEmailToken' => null
03:35:55         'mEmailTokenExpires' => null
03:35:55         'mRegistration' => null
03:35:55         'mEditCount' => null
03:35:55         'mGroups' => null
03:35:55         'mGroupMemberships' => null
03:35:55         'mOptionOverrides' => null
03:35:55         'mOptionsLoaded' => false
03:35:55         'mLoadedItems' => Array &0 (
03:35:55             'name' => true
03:35:55         )
03:35:55         'mFrom' => 'name'
03:35:55         'mNewtalk' => -1
03:35:55         'mDatePreference' => null
03:35:55         'mBlockedby' => -1
03:35:55         'mHash' => false
03:35:55         'mRights' => null
03:35:55         'mBlockreason' => null
03:35:55         'mEffectiveGroups' => null
03:35:55         'mImplicitGroups' => null
03:35:55         'mFormerGroups' => null
03:35:55         'mGlobalBlock' => null
03:35:55         'mLocked' => null
03:35:55         'mHideName' => null
03:35:55         'mOptions' => null
03:35:55         'mRequest' => null
03:35:55         'mBlock' => null
03:35:55         'mAllowUsertalk' => null
03:35:55         'mBlockedFromCreateAccount' => false
03:35:55         'queryFlagsUsed' => 0
03:35:55     )
03:35:55     'forcedTargetID' => null
03:35:55     'type' => 1
03:35:55     'blocker' => User Object &0000000000000000feaa6a4d0934a794 (
03:35:55         'mId' => 1
03:35:55         'mName' => 'UTSysop'
03:35:55         'mRealName' => 'Name 8f4931.001'
03:35:55         'mEmail' => '8f4931.018@mediawiki.test'
03:35:55         'mTouched' => '20171230033527'
03:35:55         'mQuickTouched' => null
03:35:55         'mToken' => '4d23bdb29a1028b44862b6a6d5472041'
03:35:55         'mEmailAuthenticated' => null
03:35:55         'mEmailToken' => null
03:35:55         'mEmailTokenExpires' => null
03:35:55         'mRegistration' => '20171230033335'
03:35:55         'mEditCount' => '702'
03:35:55         'mGroups' => null
03:35:55         'mGroupMemberships' => Array &1 (
03:35:55             'bureaucrat' => UserGroupMembership Object &0000000000000000feaa6a4d093d4a84 (
03:35:55                 'userId' => 1
03:35:55                 'group' => 'bureaucrat'
03:35:55                 'expiry' => null
03:35:55             )
03:35:55             'sysop' => UserGroupMembership Object &0000000000000000feaa6a4d093d4bc4 (
03:35:55                 'userId' => 1
03:35:55                 'group' => 'sysop'
03:35:55                 'expiry' => null
03:35:55             )
03:35:55         )
03:35:55         'mOptionOverrides' => Array &1
03:35:55         'mOptionsLoaded' => true
03:35:55         'mLoadedItems' => true
03:35:55         'mFrom' => 'id'
03:35:55         'mNewtalk' => -1
03:35:55         'mDatePreference' => null
03:35:55         'mBlockedby' => -1
03:35:55         'mHash' => false
03:35:55         'mRights' => null
03:35:55         'mBlockreason' => null
03:35:55         'mEffectiveGroups' => null
03:35:55         'mImplicitGroups' => null
03:35:55         'mFormerGroups' => null
03:35:55         'mGlobalBlock' => null
03:35:55         'mLocked' => null
03:35:55         'mHideName' => null
03:35:55         'mOptions' => Array &1
03:35:55         'mRequest' => null
03:35:55         'mBlock' => null
03:35:55         'mAllowUsertalk' => null
03:35:55         'mBlockedFromCreateAccount' => false
03:35:55         'queryFlagsUsed' => 0
03:35:55     )
03:35:55     'isHardblock' => true
03:35:55     'isAutoblocking' => '1'
03:35:55     'systemBlockType' => null
03:35:55 ) is null.
03:35:55 
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:812
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:55 
03:35:55 5) UserTest::testAutoblockCookieInauthentic
03:35:55 Failed to insert block
03:35:55 Failed asserting that false is true.
03:35:55 
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:840
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:55 
03:35:55 6) UserTest::testAutoblockCookieNoSecretKey
03:35:55 Failed to insert block
03:35:55 Failed asserting that false is true.
03:35:55 
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/includes/user/UserTest.php:885
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/tests/phpunit/MediaWikiTestCase.php:418
03:35:55 /home/jenkins/workspace/mediawiki-phpunit-hhvm-jessie/src/maintenance/doMaintenance.php:94
03:35:55

Event Timeline

Reedy created this task.Dec 30 2017, 4:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 30 2017, 4:09 AM
Reedy added a comment.Dec 30 2017, 4:12 AM

Attempting to narrow down cause in https://gerrit.wikimedia.org/r/400997 and https://gerrit.wikimedia.org/r/400998

Reedy renamed this task from Flaky user tests/Moving folder in tests/phpunit shouldn't cause user test breakages to Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages.Dec 30 2017, 4:21 AM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)
Reedy added a comment.Dec 30 2017, 4:58 AM

And to narrow it down further... includes/storage is fine https://gerrit.wikimedia.org/r/401001 tests/phpunit/includes/Storage is not https://gerrit.wikimedia.org/r/#/c/401000/

Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.Jan 1 2018, 10:19 AM
Addshore added a subscriber: Addshore.
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 15 2018, 12:56 PM
CCicalese_WMF added projects: Platform Engineering (Needs Cleaning - Code Health (TEC13)), Platform Team Legacy (Later).Oct 3 2018, 6:58 PM
CCicalese_WMF moved this task from Next to Later on the Multi-Content-Revisions board.Oct 3 2018, 7:08 PM
CCicalese_WMF moved this task from Later to Watching on the Multi-Content-Revisions board.Oct 4 2018, 3:04 PM
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 3:43 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
WDoranWMF added a subscriber: WDoranWMF.Jul 9 2019, 7:20 PM

@Reedy Is this task still relevant to be looked into?

WDoranWMF closed this task as Declined.Aug 27 2019, 6:10 PM

Closing but please feel free to reopen if still occurring.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL