[Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	01tonythomas
	Dec 30 2017, 4:00 PM

Description

Follow instructions as per https://phabricator.wikimedia.org/T183817 to mock an API edit an existing Newsletter FooBarExists. This unit test should:

The original newsletter (Newsletter:FooBarExists) can be created without using APIEdits, and just by new Newsletter() with values.

Try adding publishers by adding an array of users which exists like:

"publishers": [
    "userName",
    "userName1", 
]

etc. On save, make sure that:

these users are publishers of the newsletter
these users are subscribed to the newsletter

bonus - make sure that an Echo notification was sent to them ?

Details

	Subject	Repo	Branch	Lines +/-
	Add unit test for adding publishers via API	mediawiki/extensions/Newsletter	master	+73 -34

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Pppery	T183817 [Unit testing] Add unit tests to API operations on Newsletter namespace
Resolved	Pppery	T183819 [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes
Resolved	Pppery	T183820 [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work

Event Timeline

01tonythomas created this task.Dec 30 2017, 4:00 PM

Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Dec 31 2017, 1:14 PM

Change 401189 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Add unit test for adding publishers via API

https://gerrit.wikimedia.org/r/401189

gerritbot added a project: Patch-For-Review.Dec 31 2017, 6:40 PM

Pppery claimed this task.Dec 31 2017, 6:44 PM

Change 401189 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Add unit test for adding publishers via API

https://gerrit.wikimedia.org/r/401189