Page MenuHomePhabricator

Suggestions with the same percentage are not sorted by usage
Closed, ResolvedPublic2 Estimated Story Points


Suggestions with the same matching percentage are not sorted by usage. as shown in the screenshot:

Unsorted matches.png (350×1 px, 17 KB)

Event Timeline

Nikerabbit set the point value for this task to 2.Mar 1 2022, 8:18 AM
Nikerabbit lowered the priority of this task from Medium to Low.Mar 1 2022, 9:39 AM

image.png (480×1 px, 120 KB)

  1. I am concerned about the sorting of the suggestions using both the quality and count properties. Which one should take precedence?

There's nothing in the code to suggest that the suggestions with quality of 1 will always appear at the top of the list of suggestions.

Change 770448 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Sort suggestions with same percentage by usage

Here's my recommendation:

  1. Sort on the basis of similarity / matching % (100%)
  2. Then sort on the basis of the number of uses

Currently the order is done on the backend. See:

I recommend doing the sorting on the basis of usage there itself if possible.

Sorting with Eugene's latest patch and test data:

image.png (600×984 px, 71 KB)

Change 770448 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Translation Memory: Sort suggestions with same percentage by usage