DisallowSpaceIndent sniff fails to detect incorrect use of spaces
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Huji
	Jan 1 2018, 10:39 PM

Description

See https://gerrit.wikimedia.org/r/#/c/401410/3/maintenance/loginAttempt.php

I had accidentally used two spaces instead of a tab in certain lines, and CodeSniffer failed to detect it.

class LoginAttempt extends Maintenance {
»	/**
»	 * Constructor
»	 *
»	 * Retrieves the arguments from the command line
»	 */
  public function __construct() {
^^ problem
»	»	parent::__construct();
»	»	$this->requireExtension( 'LoginNotify' );
»	}
}

Event Timeline

Huji created this task.Jan 1 2018, 10:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 1 2018, 10:39 PM

It seems Generic.WhiteSpace.DisallowSpaceIndent is only triggered when the count of spaces is equal to the usually tab width of 4, more or less spaces are not checked by that sniff (from my understanding of the code).

So this needs an own sniff or a option for the usptream one.

Umherirrender updated the task description. (Show Details)Jan 7 2018, 12:01 AM

Krinkle renamed this task from CodeSniffer failed to detect incorrect use of spaces to DisallowSpaceIndent sniff fails to detect incorrect use of spaces.Apr 16 2018, 11:43 PM

Krinkle moved this task from Untriaged to Accepted rule changes on the MediaWiki-Codesniffer board.

Krinkle triaged this task as Medium priority.Sep 8 2019, 1:27 AM

Krinkle updated the task description. (Show Details)

Umherirrender unsubscribed.Feb 27 2021, 12:25 PM

Jdforrester-WMF subscribed.Sep 11 2023, 8:49 PM

DisallowSpaceIndent sniff fails to detect incorrect use of spacesOpen, MediumPublicActions

Description

Event Timeline

DisallowSpaceIndent sniff fails to detect incorrect use of spaces
Open, MediumPublic
Actions