Page MenuHomePhabricator

ApiDelete should have PHPUnit tests for deleting non-file pages
Closed, ResolvedPublic


In MediaWiki core, the ApiDelete module allows deleting pages, is a pretty important module, and should have tests.

If you're not already familiar with PHPUnit tests, has links to some good material on the basics of testing.

I would also recommend looking at other tests in the tests/phpunit/includes/api directory of MediaWiki core for an example of how we currently test API modules. For the purposes of this GCI task, only worry about testing deletion of normal pages, not files, which have special handling.

I'll mentor this for Google-Code-in-2017

Event Timeline

Legoktm created this task.Jan 2 2018, 5:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2018, 5:36 AM
Anomie moved this task from Unsorted to Needs Code on the MediaWiki-API board.Jan 2 2018, 3:41 PM

Change 404150 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[mediawiki/core@master] Add PHPUnit for ApiDelete for deleting non-file pages

Change 404150 merged by jenkins-bot:
[mediawiki/core@master] Add PHPUnit tests for ApiDelete

Legoktm closed this task as Resolved.Jan 18 2018, 4:19 PM
Legoktm claimed this task.
Legoktm reassigned this task from Legoktm to eflyjason.Jan 18 2018, 5:05 PM