ApiDelete should have PHPUnit tests for deleting non-file pages
Closed, ResolvedPublic
Actions

Description

In MediaWiki core, the ApiDelete module allows deleting pages, is a pretty important module, and should have tests.

If you're not already familiar with PHPUnit tests, https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing.

I would also recommend looking at other tests in the tests/phpunit/includes/api directory of MediaWiki core for an example of how we currently test API modules. For the purposes of this GCI task, only worry about testing deletion of normal pages, not files, which have special handling.

I'll mentor this for Google-Code-in-2017

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+79 -0	Add PHPUnit tests for ApiDelete

Customize query in gerrit

Event Timeline

Legoktm created this task.Jan 2 2018, 5:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2018, 5:36 AM

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-API board.Jan 2 2018, 3:41 PM

Published as https://codein.withgoogle.com/tasks/6435912021966848/

eflyjason added a subscriber: eflyjason.Jan 14 2018, 9:42 AM

Change 404150 had a related patch set uploaded (by Eflyjason; owner: Eflyjason):
[mediawiki/core@master] Add PHPUnit for ApiDelete for deleting non-file pages

https://gerrit.wikimedia.org/r/404150

gerritbot added a project: Patch-For-Review.Jan 14 2018, 9:56 AM

Change 404150 merged by jenkins-bot:
[mediawiki/core@master] Add PHPUnit tests for ApiDelete

https://gerrit.wikimedia.org/r/404150

Legoktm closed this task as Resolved.Jan 18 2018, 4:19 PM

Legoktm claimed this task.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 18 2018, 5:00 PM

Legoktm reassigned this task from Legoktm to eflyjason.Jan 18 2018, 5:05 PM