Page MenuHomePhabricator
Create Task
Maniphest T183926

Limit http methods reported by varnishmtail
Closed, ResolvedPublic
Actions

Description

There's a wide selection of http methods reported by varnishmtail, since it is user-controlled we should be reporting only valid methods, e.g.

OPTIONS
GET
HEAD
POST
PUT
DELETE
TRACE
CONNECT
PURGE
PATCH

Details

SubjectRepoBranchLines +/-
mtail: fix counting for frontend varnish http_methodoperations/puppetproduction+1 -1
mtail: group invalid methods under a single metricoperations/puppetproduction+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

fgiunchedi triaged this task as Medium priority.Jan 2 2018, 4:44 PM
fgiunchedi created this task.
• ema moved this task from Backlog to Caching on the Traffic board.Jan 3 2018, 8:49 AM
gerritbot added a comment.Jan 5 2018, 10:09 AM

Change 402318 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] mtail: group invalid methods under a single metric

https://gerrit.wikimedia.org/r/402318

gerritbot added a project: Patch-For-Review.Jan 5 2018, 10:09 AM
gerritbot added a comment.Jan 5 2018, 11:47 AM

Change 402318 merged by Filippo Giunchedi:
[operations/puppet@production] mtail: group invalid methods under a single metric

https://gerrit.wikimedia.org/r/402318

fgiunchedi closed this task as Resolved.Jan 5 2018, 1:25 PM
fgiunchedi claimed this task.
fgiunchedi reopened this task as Open.Jan 9 2018, 10:52 AM

Reopening, we need to match method names exactly, not prefixes like we're doing now

gerritbot added a comment.Jan 9 2018, 2:10 PM

Change 403158 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] mtail: fix counting for frontend varnish http_method

https://gerrit.wikimedia.org/r/403158

gerritbot added a comment.Jan 9 2018, 2:17 PM

Change 403158 merged by Filippo Giunchedi:
[operations/puppet@production] mtail: fix counting for frontend varnish http_method

https://gerrit.wikimedia.org/r/403158

fgiunchedi closed this task as Resolved.Jan 9 2018, 4:41 PM

Fixed and rolled out

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL