Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce

Visit my sandbox page
Edit the "There are known knowns" section using the 2017 VisualWikitext editor (Note: Don't use the 'Edit source' in the top of the page. Use the 'Edit source' link near the section heading)
Review your changes as a VisualDiff

Actual results

Every other section is shown as deleted in the VisualDiff along with the change done to the section even though that is not the case.

Expected results

Only the change done to the section should be shown.

NOTE: This doesn't seem to be an issue with VisualEditor as clicking on 'Edit' link on a section starts VisualEditor on the whole page showing the current section. This seems to specific to the 2017 VisualWikitext editor, so tagging it.

Environment details

Browser: Firefox Nightly 59.0a1
OS: Debian GNU/Linux 9 (stretch)
Skin: Vector

This was initially reported in the feedback page for VisualDiffs https://www.mediawiki.org/wiki/Topic:U4gz8ed64lgerqqd

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Disable visual diffs on source mode section edits	mediawiki/extensions/VisualEditor	master	+9 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Esanders	T190845 Show visual diffs on source mode section edits
Resolved	Esanders	T183938 Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly)
Declined	Esanders	T190310 Indicate to user why visual diffs are disabled on section edit

Event Timeline

Kaartic created this task.Jan 2 2018, 5:22 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 2 2018, 5:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Also occurs in the following environment,

Browser: Firefox 57.0.3 (64-bit)
OS: Arch Linux
Skin: Vector (default).

• Deskana renamed this task from Section editing shows every other section to have been deleted to Visual diff on a section edit shows every other section to have been deleted (but the edit saves correctly).Jan 2 2018, 5:25 PM

• Deskana triaged this task as High priority.

• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

• Deskana set the point value for this task to 1.

• Elitre subscribed.Jan 3 2018, 9:41 AM

simon04 subscribed.Jan 4 2018, 6:07 PM

Showing visual diffs from wikitext mode is a lower priority than the normal visual diff feature.

Given this will require matching up wikitext sections with Parsoid sections, I think I'll probably just disable visual mode when WT section editing.

Mvolz subscribed.Feb 22 2018, 10:56 PM

Liuxinyu970226 subscribed.Feb 24 2018, 12:12 PM

Schnark subscribed.Feb 27 2018, 10:24 AM

Change 418701 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Disable visual diffs on source mode section edits

https://gerrit.wikimedia.org/r/418701

gerritbot added a project: Patch-For-Review.Mar 10 2018, 11:02 PM

Schnark mentioned this in T190018: Message <visualeditor-diff-timed-out> missing at least in NWE preview.Mar 19 2018, 8:14 AM

Jdforrester-WMF assigned this task to Esanders.Mar 20 2018, 10:53 PM

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed Patch-For-Review, VisualEditor.

Jdforrester-WMF moved this task from Incoming to Product owner review on the VisualEditor (Current work) board.

Change 418701 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Disable visual diffs on source mode section edits

https://gerrit.wikimedia.org/r/418701

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 12:01 AM

Looking at the code, it seems like it keeps the button there, but greys it out. That's good. I wonder could we indicate to the user somehow why it's greyed out? That should be a separate task, anyway.

• Deskana mentioned this in T190310: Indicate to user why visual diffs are disabled on section edit.Mar 21 2018, 5:07 PM

Liuxinyu970226 unsubscribed.Mar 23 2018, 1:01 AM

Esanders added a parent task: T190845: Show visual diffs on source mode section edits.Mar 27 2018, 4:53 PM

Esanders closed subtask T190310: Indicate to user why visual diffs are disabled on section edit as Declined.Mar 27 2018, 4:58 PM