Page MenuHomePhabricator

download_dump.py: Move the file location from `scripts/maintenance` to `scripts`
Open, NormalPublic

Description

As stated in https://gerrit.wikimedia.org/r/#/c/401377/4/scripts/maintenance/download_dump.py@49 and in https://phabricator.wikimedia.org/T123885 , the download_dump.py isn't meant to be a maintenance script, it should be placed in the scripts directory.

Event Timeline

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 3 2018, 4:30 AM
rafidaslam triaged this task as Normal priority.Jan 3 2018, 4:32 AM

Change 401674 had a related patch set uploaded (by Rafidaslam; owner: rafid):
[pywikibot/core@master] download_dump: Move the file to scripts

https://gerrit.wikimedia.org/r/401674

jayvdb added a subscriber: jayvdb.Jan 3 2018, 8:31 AM

This was done at my request during code review because this script wasnt being tested with tests/script_tests.py which it should be.

This script is not a maintenance script. maintenance scripts are not tested, because they are used for scripts used to maintain pywikibot only.

scripts has a wide variety of contents, including tools which dont do anything, like version & shell, and scripts which only work on wikimedia sites, like all of the Wikidata specific scripts. Those are not reasons to put it under a different directory.
If anyone is insisting that it must be under maintenance, then they must improve the test framework to test maintenance scripts also.
Otherwise I turn off all pywikibot GCI tasks related to this script because they are bypassing the test suite as it exists.

jayvdb added a subscriber: Xqt.Jan 3 2018, 8:32 AM
D3r1ck01 moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:27 AM