As stated in https://gerrit.wikimedia.org/r/#/c/401377/4/scripts/maintenance/download_dump.py@49 and in https://phabricator.wikimedia.org/T123885 , the download_dump.py isn't meant to be a maintenance script, it should be placed in the scripts directory.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| download_dump: Move the file to `scripts` | pywikibot/core | master | +5 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T183663 Improve the maintenance script that download Wikimedia database dump | |||
| Resolved | rafidaslam | T184033 download_dump.py: Move the file location from `scripts/maintenance` to `scripts` |
Event Timeline
Comment Actions
Change 401674 had a related patch set uploaded (by Rafidaslam; owner: rafid):
[pywikibot/core@master] download_dump: Move the file to scripts
Comment Actions
This was done at my request during code review because this script wasnt being tested with tests/script_tests.py which it should be.
This script is not a maintenance script. maintenance scripts are not tested, because they are used for scripts used to maintain pywikibot only.
scripts has a wide variety of contents, including tools which dont do anything, like version & shell, and scripts which only work on wikimedia sites, like all of the Wikidata specific scripts. Those are not reasons to put it under a different directory.
If anyone is insisting that it must be under maintenance, then they must improve the test framework to test maintenance scripts also.
Otherwise I turn off all pywikibot GCI tasks related to this script because they are bypassing the test suite as it exists.
Comment Actions
Change 401674 merged by jenkins-bot:
[pywikibot/core@master] download_dump: Move the file to scripts