Page MenuHomePhabricator
Create Task
Maniphest T184037

Cite: Replace "getSelectedItem" with "findSelectedItem"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We would like to rename some get() functions for naming consistency.

Replace instances of getSelectedItem with findSelectedItem in modules/ve-cite/ve.ui.MWReferenceSearchWidget.js in MediaWiki's Cite extension.

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Details

SubjectRepoBranchLines +/-
Replace "getSelectedItem" with "findSelectedItem" for consistencymediawiki/extensions/Citemaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Prtksxna triaged this task as Lowest priority.Jan 3 2018, 5:55 AM
• Prtksxna created this task.
• Prtksxna mentioned this in T76630: Rename a lot of getters for consistency.
Florian added a comment.Jan 3 2018, 10:34 AM

Does this depend on https://gerrit.wikimedia.org/r/#/c/398005/1?

Aklapper updated the task description. (Show Details)Jan 3 2018, 4:11 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Jan 3 2018, 4:16 PM

Thanks! Published as https://codein.withgoogle.com/tasks/6700266185293824/

• Prtksxna added a comment.Jan 4 2018, 1:49 AM
In T184037#3870922, @Florian wrote:

Does this depend on https://gerrit.wikimedia.org/r/#/c/398005/1?

Yes. That, and OOUI being updated in core. Once done, I was planning to accept on the GCI site but merge on Gerrit only once things are ready in core.

Florian added a comment.Jan 4 2018, 10:06 AM

Ah, ok, +1! @Aklapper already imported the task :P

gerritbot subscribed.Jan 10 2018, 2:56 AM

Change 403338 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Cite@master] Replace "getSelectedItem" with "findSelectedItem"

https://gerrit.wikimedia.org/r/403338

gerritbot added a project: Patch-For-Review.Jan 10 2018, 2:56 AM
Kizule claimed this task.Jan 10 2018, 2:57 AM
Restricted Application added a project: User-Kizule. · View Herald TranscriptJan 10 2018, 2:57 AM
Kizule moved this task from Inbox to Blocked on the User-Kizule board.Jan 10 2018, 2:57 AM
Kizule moved this task from Backlog to Doing on the OOUI board.
Jdforrester-WMF closed this task as Resolved.Jan 10 2018, 8:15 PM
Jdforrester-WMF edited projects, added Cite, VisualEditor; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 10 2018, 8:15 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Jan 10 2018, 8:15 PM
gerritbot added a comment.Jan 10 2018, 8:33 PM

Change 403338 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Replace "getSelectedItem" with "findSelectedItem" for consistency

https://gerrit.wikimedia.org/r/403338

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 10 2018, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL