Page MenuHomePhabricator
Create Task
Maniphest T184040

TemplateData: Replace "getSelectedItem" with "findSelectedItem"
Closed, ResolvedPublic
Actions

Description

We would like to rename some get() functions for naming consistency.

Replace instances of getSelectedItem with findSelectedItem in modules/ext.templateDataGenerator.ui.tdDialog.js in MediaWiki's TemplateData extension.

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Details

SubjectRepoBranchLines +/-
Replace "getSelectedItem" with "findSelectedItem" for consistencymediawiki/extensions/TemplateDatamaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Prtksxna triaged this task as Lowest priority.Jan 3 2018, 6:12 AM
• Prtksxna created this task.
• Prtksxna mentioned this in T76630: Rename a lot of getters for consistency.Jan 3 2018, 6:24 AM
Aklapper updated the task description. (Show Details)Jan 3 2018, 4:11 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Jan 3 2018, 4:15 PM

Thanks! Published as https://codein.withgoogle.com/tasks/6579730612486144/

gerritbot subscribed.Jan 9 2018, 10:33 PM

Change 403309 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/TemplateData@master] TemplateData: Replace "getSelectedItem" with "findSelectedItem"

https://gerrit.wikimedia.org/r/403309

gerritbot added a project: Patch-For-Review.Jan 9 2018, 10:33 PM
Kizule moved this task from Backlog to Doing on the OOUI board.Jan 9 2018, 10:41 PM
Kizule added a project: User-Kizule.
Kizule moved this task from Inbox to Scheduled for deployment (Morning SWAT between 18:00-19:00 UTC+1) on the User-Kizule board.
Kizule moved this task from Scheduled for deployment (Morning SWAT between 18:00-19:00 UTC+1) to Blocked on the User-Kizule board.Jan 9 2018, 11:04 PM
gerritbot added a comment.Jan 10 2018, 2:14 AM

Change 403309 abandoned by Zoranzoki21:
Replace "getSelectedItem" with "findSelectedItem"

Reason:
Merged in core. See comment of Prtksxna

https://gerrit.wikimedia.org/r/403309

gerritbot added a comment.Jan 10 2018, 2:18 AM

Change 403309 restored by Prtksxna:
Replace "getSelectedItem" with "findSelectedItem"

Reason:
Please don't abandon the patch, it needs to be merged later.

https://gerrit.wikimedia.org/r/403309

Jdforrester-WMF closed this task as Resolved.Jan 10 2018, 8:11 PM
Jdforrester-WMF assigned this task to Kizule.
Jdforrester-WMF subscribed.

Thank you!

Kizule added a comment.Jan 10 2018, 8:12 PM
In T184040#3891109, @Jdforrester-WMF wrote:

Thank you!

Your welcome

gerritbot added a comment.Jan 10 2018, 8:12 PM

Change 403309 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Replace "getSelectedItem" with "findSelectedItem" for consistency

https://gerrit.wikimedia.org/r/403309

Kizule moved this task from Blocked to Done on the User-Kizule board.Jan 10 2018, 8:13 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 10 2018, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL