Setup gitiles to use a repo viewer.
This task is used a log to track it being installed as a gerrit plugin in prod.
Questions:
Do we want to have a seperate domain for this or do we just want gerrit.wikimedia.org/plugins/gitiles?
Setup gitiles to use a repo viewer.
This task is used a log to track it being installed as a gerrit plugin in prod.
Questions:
Do we want to have a seperate domain for this or do we just want gerrit.wikimedia.org/plugins/gitiles?
I like gitiles better than Diffusion or Github links. I think it's great if i can do code review and view repos in the same tool (Gerrit). So +1 to using that plugin. Also per IRC chat with no_justification.
Change 401799 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Set gitiles configuation to be used as the repo viewer
gitiles is now installed and can be accessed at https://gerrit.wikimedia.org/r/plugins/gitiles/
Problem with second domain is that I dunno how well it'd work with being logged in (gitiles respects ACLs, one of the reasons I wanted to go the plugin route instead of Phab)....unless we did something funky with the cookie domain? We can and should do some rewrites though, "/r/plugins/gitiles/" could be one word...I saw "view" and "git" suggested on IRC...I'd go a step further and just use "g" for gitiles/git.
I agree we should _not_ use a second domain, yea. Also the short version with just "g" or something similar seems nice.
What's up with https://gerrit.wikimedia.org/r/#/c/401799/ now btw?
Change 409211 had a related patch set uploaded (by Chad; owner: Chad):
[operations/puppet@production] Gerrit: Proxy gitiles through gerrit.wikimedia.org/g/
Regarding cookies, the GerritAccount cookie has a path set of /r, so visiting gerrit.wikimedia.org/g/ shows me as logged out.
Change 401799 merged by Dzahn:
[operations/puppet@production] Gerrit: Set gitiles configuation to be used as the repo viewer
Change 409211 merged by Dzahn:
[operations/puppet@production] Gerrit: Proxy gitiles through gerrit.wikimedia.org/g/