Page MenuHomePhabricator
Create Task
Maniphest T184140

Increase coverage of ORES extension
Closed, ResolvedPublic
Actions

Description

This task is done when coverage of ORES extension is above 60%, current value: 38%: https://doc.wikimedia.org/cover/extensions/ORES/index.html

Classes needing the most tests:

Api class also lacks tests but I'm planning to rewrite the class from scratch.

Details

SubjectRepoBranchLines +/-
Tests for PopulateDatabasemediawiki/extensions/ORESmaster+179 -0
Add a maintenance script testmediawiki/extensions/ORESmaster+198 -3
Steal model fixtures for TestHelper; add dirty tricksmediawiki/extensions/ORESmaster+62 -45
Namespace maintenance scripts so they're discoverable from testsmediawiki/extensions/ORESmaster+6 -4
Add more WatchedItemQueryServiceExtension tests.mediawiki/extensions/ORESmaster+66 -4
Tests for WatchedItemQueryServiceExtensionmediawiki/extensions/ORESmaster+120 -0
Mostly cover ORES\Hooksmediawiki/extensions/ORESmaster+170 -0
Mostly cover ChangesListHooksHandlermediawiki/extensions/ORESmaster+86 -49
Tests for FetchScoreJobmediawiki/extensions/ORESmaster+166 -3
Add tests for HashModelLookupmediawiki/extensions/ORESmaster+74 -0
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jan 4 2018, 12:20 AM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 4 2018, 12:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jan 6 2018, 6:47 AM

Change 402485 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Tests for FetchScoreJob

https://gerrit.wikimedia.org/r/402485

gerritbot added a project: Patch-For-Review.Jan 6 2018, 6:47 AM
Ladsgroup updated the task description. (Show Details)Jan 6 2018, 6:47 AM
gerritbot added a comment.Jan 6 2018, 7:00 AM

Change 402486 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Add tests for HashModelLookup

https://gerrit.wikimedia.org/r/402486

Ladsgroup updated the task description. (Show Details)Jan 6 2018, 7:01 AM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 6 2018, 7:36 AM
gerritbot added a comment.Jan 6 2018, 8:24 AM

Change 402486 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Add tests for HashModelLookup

https://gerrit.wikimedia.org/r/402486

gerritbot added a comment.Jan 6 2018, 8:31 AM

Change 402485 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Tests for FetchScoreJob

https://gerrit.wikimedia.org/r/402485

Ladsgroup updated the task description. (Show Details)Jan 6 2018, 8:31 AM
Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 6 2018, 9:00 AM
awight claimed this task.Jan 8 2018, 3:32 PM
gerritbot added a comment.Jan 8 2018, 6:27 PM

Change 402878 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Mostly cover ChangesListHooksHandler

https://gerrit.wikimedia.org/r/402878

gerritbot added a comment.Jan 8 2018, 10:25 PM

Change 403068 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Cover some of Hooks

https://gerrit.wikimedia.org/r/403068

gerritbot added a comment.Jan 9 2018, 8:08 PM

Change 403227 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Tests for WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/403227

gerritbot added a comment.Jan 9 2018, 8:49 PM

Change 403234 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] [WIP] Add more WatchedItemQueryServiceExtension tests.

https://gerrit.wikimedia.org/r/403234

gerritbot added a comment.Jan 10 2018, 5:10 AM

Change 402878 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Mostly cover ChangesListHooksHandler

https://gerrit.wikimedia.org/r/402878

gerritbot added a comment.Jan 10 2018, 5:10 AM

Change 403068 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Mostly cover ORES\Hooks

https://gerrit.wikimedia.org/r/403068

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 10 2018, 6:01 AM
gerritbot added a comment.Jan 10 2018, 3:36 PM

Change 403227 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Tests for WatchedItemQueryServiceExtension

https://gerrit.wikimedia.org/r/403227

gerritbot added a comment.Jan 10 2018, 8:07 PM

Change 403234 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Add more WatchedItemQueryServiceExtension tests.

https://gerrit.wikimedia.org/r/403234

gerritbot added a comment.Jan 11 2018, 2:51 PM

Change 403663 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Namespace maintenance scripts so they're discoverable from tests

https://gerrit.wikimedia.org/r/403663

gerritbot added a comment.Jan 11 2018, 11:18 PM

Change 403838 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Steal model fixtures for TestHelper; add dirty tricks

https://gerrit.wikimedia.org/r/403838

gerritbot added a comment.Jan 11 2018, 11:18 PM

Change 403839 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Add a maintenance script test

https://gerrit.wikimedia.org/r/403839

gerritbot added a comment.Jan 12 2018, 12:24 AM

Change 403870 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] [WIP] Tests for PopulateDatabase

https://gerrit.wikimedia.org/r/403870

gerritbot added a comment.Jan 12 2018, 10:24 AM

Change 403663 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Namespace maintenance scripts so they're discoverable from tests

https://gerrit.wikimedia.org/r/403663

gerritbot added a comment.Jan 12 2018, 10:26 AM

Change 403838 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Steal model fixtures for TestHelper; add dirty tricks

https://gerrit.wikimedia.org/r/403838

gerritbot added a comment.Jan 12 2018, 10:30 AM

Change 403839 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Add a maintenance script test

https://gerrit.wikimedia.org/r/403839

gerritbot added a comment.Jan 17 2018, 9:36 PM

Change 403870 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Tests for PopulateDatabase

https://gerrit.wikimedia.org/r/403870

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 17 2018, 10:00 PM
awight moved this task from Parked to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 18 2018, 7:27 PM
awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM
Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL