Page MenuHomePhabricator

Interaction Timeline: Add a sane default value for the start date
Closed, DuplicatePublic1 Estimated Story Points

Description

Problem

Currently there is no default, meaning that we typically have to look at all the revisions since the beginning of time. In most cases, we only need to see interactions from the past year, so it might be best to set the default to 1 year ago. This should improve performance in most cases.


Acceptance criteria

  • The default value for 'Start Date' should be 365 days before the current date (e.g. if you are looking at February 1, 2018 the start date should be February 1, 2017.)

Event Timeline

@TBolliger: This is just an idea I had. Feel free to rewrite or discard.

Great thinking. I'm going to roll this into the Acceptance criteria of T180406: Interaction Timeline V1: Better date picker

Great thinking. I'm going to roll this into the Acceptance criteria of T180406: Interaction Timeline V1: Better date picker

Darn I liked it better being separate.

Smaller Tasks are almost always better. :)

TBolliger renamed this task from Add a sane default value for the start date in InteractionTimeline to Interaction Timeline: Add a sane default value for the start date.Jan 16 2018, 5:52 PM
TBolliger reopened this task as Open.
TBolliger updated the task description. (Show Details)

Great thinking. I'm going to roll this into the Acceptance criteria of T180406: Interaction Timeline V1: Better date picker

Darn I liked it better being separate.

Smaller Tasks are almost always better. :)

Okie doke! Feel free to split cards in the future as you see fit, Phabricator should serve our team's needs, not nice-versa.

@TBolliger With T187406 and T185459, if you don't specify a Start Date, you'll get a single page of results at the beginning of the users' interaction. Because of that, I think we should decline this task in favor of doing the other two.

The reason why I'm thinking this is because with this task, we have to differentiate between when a timeline user intentionally leaves it blank and when they want the default. I think the best way to do this is to set it when the page is loaded, if there is no query in the URL, we'll set the default at that point, if there is a query, we wont.

What do you think @dmaza ?

if you don't specify a Start Date, you'll get a single page of results at the beginning of the users' interaction

This is not what T187406 say. We'll start showing results after the newer user's registration page. That can still be a few years back.

I think the best way to do this is to set it when the page is loaded, if there is no query in the URL

I'd go with that ^^^ . If there is no query in the URL (meaning no user/date/wiki) then we can default to -1 year (or whatever)

if you don't specify a Start Date, you'll get a single page of results at the beginning of the users' interaction

This is not what T187406 say. We'll start showing results after the newer user's registration page. That can still be a few years back.

Let's say User:Apples first edit was on February 16th 2006 and User:Bananas first edit was on March 18th 2014. True, you might not care about what happened between 2014 - 2018, but we know for sure that you really don't care about what happened before 2014.