Page MenuHomePhabricator

role::wikimediaproduction should compile into a catalogue without dependency cycles
Closed, ResolvedPublic

Description

4) role::wikimediaproduction should compile into a catalogue without dependency cycles
   Failure/Error: it { is_expected.to compile }
     error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Mediawiki::Extension[GlobalUsage] is already declared in file /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/commons.pp:32; cannot redeclare at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/globalusage.pp:5 at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/globalusage.pp:5:5 on node wmf-bd808-mbp01.local
   # ./puppet/spec/integration/roles_spec.rb:20:in `block (3 levels) in <top (required)>'

Event Timeline

bd808 created this task.Jan 4 2018, 4:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2018, 4:59 AM
bd808 added a comment.Jan 4 2018, 6:16 AM
3) role::wikimediaproduction should compile into a catalogue without dependency cycles
   Failure/Error: it { is_expected.to compile }
     error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Mediawiki::Extension[LabeledSectionTransclusion] is already declared in file /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/labeledsectiontransclusion.pp:5; cannot redeclare at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/proofreadpage.pp:19 at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/role/manifests/proofreadpage.pp:19:5 on node wmf-bd808-mbp01.local
   # ./puppet/spec/integration/roles_spec.rb:20:in `block (3 levels) in <top (required)>'

Change 401898 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[mediawiki/vagrant@stretch-migration] wikimediaproduction: Remove duplicate declaration conflicts

https://gerrit.wikimedia.org/r/401898

bd808 claimed this task.Jan 4 2018, 6:20 AM

Change 401898 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] wikimediaproduction: Remove duplicate declaration conflicts

https://gerrit.wikimedia.org/r/401898

bd808 closed this task as Resolved.Jan 6 2018, 4:48 PM

There are still several problems with provisioning role::wikimediaproduction but the duplications and cycles are fixed now.