Visual diff shows signature as tildes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Schnark
	Jan 4 2018, 8:49 AM

Description

Open a talk page for editing in NWE (or VE if you find a wiki that has a namespace with both VE and signatures).
Add four tildes as signature somewhere.
Start saving, and review your changes as visual diff.

Expected:
The tildes are expanded as signature (as in the wikitext diff).

Actual:
The tildes are shown as tildes.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show signatures in NWE visual diff	mediawiki/extensions/VisualEditor	master	+10 -9

Customize query in gerrit

Event Timeline

Schnark created this task.Jan 4 2018, 8:49 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 4 2018, 8:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is because we are getting the result directly from Parsoid without doing a pre-save transform.

• Deskana triaged this task as Medium priority.Jan 9 2018, 4:31 PM

• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

• Deskana set the point value for this task to 1.

Visual diffs is currently showing me nothing instead of either the signature or the tildes on office.wiki.

Tchanders claimed this task.Aug 16 2018, 7:36 PM

Tchanders moved this task from TR6: Visual diffs to Current work on the VisualEditor board.

Tchanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Tchanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Change 453264 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Show signatures in NWE visual diff

https://gerrit.wikimedia.org/r/453264

gerritbot added a project: Patch-For-Review.Aug 16 2018, 8:54 PM

Jdforrester-WMF moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 16 2018, 11:25 PM

Change 453264 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Show signatures in NWE visual diff

https://gerrit.wikimedia.org/r/453264

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 17 2018, 2:00 PM

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 17 2018, 3:50 PM

Jdforrester-WMF removed a project: Patch-For-Review.Aug 17 2018, 5:18 PM

Ryasmeen added a project: Verified.Aug 31 2018, 8:34 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Sep 2 2018, 2:34 PM

Visual diff shows signature as tildesClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Visual diff shows signature as tildes
Closed, ResolvedPublic1 Estimated Story Points
Actions