Page MenuHomePhabricator

Visual diff shows signature as tildes
Closed, ResolvedPublic1 Estimated Story Points

Description

  1. Open a talk page for editing in NWE (or VE if you find a wiki that has a namespace with both VE and signatures).
  2. Add four tildes as signature somewhere.
  3. Start saving, and review your changes as visual diff.

Expected:
The tildes are expanded as signature (as in the wikitext diff).

Actual:
The tildes are shown as tildes.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is because we are getting the result directly from Parsoid without doing a pre-save transform.

Deskana triaged this task as Medium priority.Jan 9 2018, 4:31 PM
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Deskana set the point value for this task to 1.

Visual diffs is currently showing me nothing instead of either the signature or the tildes on office.wiki.

Change 453264 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/VisualEditor@master] Show signatures in NWE visual diff

https://gerrit.wikimedia.org/r/453264

Change 453264 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Show signatures in NWE visual diff

https://gerrit.wikimedia.org/r/453264