Page MenuHomePhabricator

Bookmarking Watchlist with new filters does not preserve user Watchlist preferences
Open, Needs TriagePublic

Description

I have the Option

  • Expand watchlist to show all changes, not just the most recent

activated in my settings on Wikidata. But it does not work. I disabled all Gadgets, Betatests, etc.

I found out that the option does work if I enable the Beta-feature "New filters for edit review" – and works again not if I disable the Beta-Fature. The Bug does not occur on dewiki.

Updated description:

  1. Enable the following options in Preferences -Watchlist
    • "Expand watchlist to show all changes, not just the most recent"
    • "Hide edits by anonymous users from the watchlist"
  2. Enable the beta feature: "New filters for edit review"
  3. Go to the Watchlist - the default filters will reflect the user preferences - the "Registered" filters will be selected and all entries, not the most recent will be displayed.
  4. Bookmark the page.
  5. Opt-out from "New filters ..."
  6. Load the bookmark - the Watchlist preferences will be ignored.
  • With New filters
Preferences - WatchlistResult Watchlist
Screen Shot 2018-01-12 at 2.41.54 PM.png (416×698 px, 91 KB)
Screen Shot 2018-01-12 at 2.39.47 PM.png (345×848 px, 75 KB)
was bookmarked
  • Opt-out from New filters - the preferences are ignored; reloading the page does not help.
the bookmarked page (from the above)
Screen Shot 2018-01-12 at 2.42.36 PM.png (379×1 px, 135 KB)
  • click on Watchlist link - the preferences are taken into account.

Screen Shot 2018-01-12 at 2.42.54 PM.png (390×1 px, 130 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@MichaelSchoenitzer I was checking the issue in wikidata.org (1.31.0-wmf.15 ). Without beta-feature "New filters for edit review", I enabled "Expand watchlist to show all changes, not just the most recent" and there are all changes displayed:

Screen Shot 2018-01-08 at 3.26.27 PM.png (497×1 px, 226 KB)

I disabled "Expand watchlist to show all changes, not just the most recent" - and only the most recent change is displayed:

Screen Shot 2018-01-08 at 3.25.58 PM.png (266×1 px, 74 KB)

Can you re-check again? Make sure that no other options are checked in Preferences-Watchlist (e.g. 'Hide edits by logged in users from the watchlist' ).

Catrope changed the task status from Open to Stalled.Jan 9 2018, 7:13 PM

@Etonkovidova & @Trizek-WMF: I debugged a bit. When enabling the beta-feature "New filters for edit review" the url of the watchlist gets additional arguments. Without the beta-feature the url of the watchlist is:
https://www.wikidata.org/wiki/Special:Watchlist
With the beta-feature the url reads like:
https://www.wikidata.org/wiki/Special:Watchlist?hidemyself=1&hidebots=1&hidecategorization=1&limit=250&days=7&enhanced=1&urlversion=2

When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore.
This is especially an issue when you if you never close your watchlist but keep it open in a tab or have set a bookmark (while the beta-feature was enabled).

MichaelSchoenitzer changed the task status from Stalled to Open.Jan 9 2018, 8:00 PM

Thank you, @MichaelSchoenitzer - this issue (especially bookmarking the Watchlist) certainly needs to be addressed. I am moving the task to `Collaboration -Team-Triage (Collab-Team-This-Quarter)' board.

When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore.
This is especially an issue when you if you never close your watchlist but keep it open in a tab or have set a bookmark (while the beta-feature was enabled).

Just trying to pinpoint the exact problem -- is the "enhanced" list not working at all (so, you can't change to it) or does it "just" load it initially as the wrong preference, but you're able to change it afterwards?

The issue is not specific to wikidata. In a sense, it's logical - page specific "Group results by page" option will not be preserved when a user opts out of the new filters.

"New filters for edit review" beta feature is enabled; Preferences-Recent changes "Group changes by page in recent changes and watchlist" not enabled. Watchlist page filter option "Group results by page" is enabled.

https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?limit=250&days=30&enhanced=1&urlversion=2

Screen Shot 2018-01-10 at 5.41.37 PM.png (485×956 px, 136 KB)

The above url was bookmarked. Then, the user opts out from "New filters for edit review" beta feature and loads bookmarked ulr:

Screen Shot 2018-01-10 at 5.44.00 PM.png (427×941 px, 131 KB)

The 'group results by page' option works by the preference but also by the URL parameter. In the new RC system, we make the URL parameter be synchronized with the preference -- so it seems like it's the same. The old system doesn't have that synchronization, though, which means that whatever preference the user has for "group by page" will be overridden by the enhanced=xx parameter.

This is expected behavior. If you save the URL from the "new" system where more data is produced, and then you use the same URL in the old system, it will use the data that was saved -- including whether or not you had the "group by page" selected.

The 'group results by page' option works by the preference but also by the URL parameter. In the new RC system, we make the URL parameter be synchronized with the preference -- so it seems like it's the same. The old system doesn't have that synchronization, though, which means that whatever preference the user has for "group by page" will be overridden by the enhanced=xx parameter.

But that's apparently not what happens. No matter what the value of enhanced in the url is, and also when you remove the url-praramerter enhanced, you will all ways get the output without all edits.

@Mooeypoo enhanced=1 controls "group by page", it doesn't control whether the WL shows only the most recent edit for each page, or all edits, and that's what he's talking about.

@Mooeypoo enhanced=1 controls "group by page", it doesn't control whether the WL shows only the most recent edit for each page, or all edits, and that's what he's talking about.

I may have misunderstood, then. I understood we're talking about "enhanced" (group by pages) from this comment:

When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore.

Did I misunderstand?

When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore.

Did I misunderstand?

I think he may have confused the terms "enhanced" and "expanded".

@Catrope yes, sorry for the confusion - first I too thought that the issue was about enhanced=1 The problem seems to be that "Expand watchlist..." option is not saved in a bookmark when new filters are enabled. Without filters the "Expand watchlist..." can be bookmarked.

tl; dr

I rechecked the straightforward scenario:

  1. Without new filters (the beta feature) enabled, I enabled the option "Expand watchlist to show all changes, not just the most recent" in Preferences-Watchlist.

So I see the results. Notice the results are not grouped for 'Mavetuna' cause - it's only expanded to show all changes.

Screen Shot 2018-01-11 at 10.07.21 AM.png (312×944 px, 109 KB)

The url will be: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist

  1. Enable the new filters and click on Watchlist: https://en.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist?hideWikibase=1&limit=250&days=30&urlversion=2 "Expand watchlist to show all changes, not just the most recent" will not be reflected in url, but the UI will be displayed correctly:

Screen Shot 2018-01-11 at 11.51.29 AM.png (553×940 px, 151 KB)

  1. Bookmark it.
  1. Disable the new filters - and click on the bookmarked link. Only one record will be displayed - "Expand watchlist..." option was not saved in the bookmark.

Screen Shot 2018-01-11 at 11.54.00 AM.png (495×958 px, 138 KB)

  1. Reload the page - "Expand watchlist..." will take effect again.

@Etonkovidova: thanks for explaining it this good! This is exactly what was my issue.

Etonkovidova renamed this task from Expanded watchlist not working on Wikidata to Bookmarking Watchlist with new filters does not preserve user Watchlist preferences .Jan 12 2018, 10:53 PM
Etonkovidova updated the task description. (Show Details)

I am changing the title of the ticket and updating the content since the issue is not specific to Wikidata and Expanded watchlist option.