Abstract dumps broken by MW deploy
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ArielGlenn
	Jan 4 2018, 1:17 PM

Description

dumpsgen@snapshot1001:/srv/deployment/dumps/dumps/xmldumps-backup$ /usr/bin/php5 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php --wiki=gnwikibooks /srv/mediawiki/php-1.31.0-wmf.15 --plugin=AbstractFilter:/srv/mediawiki/php-1.31.0-wmf.15/extensions/ActiveAbstract/AbstractFilter.php --current --report=1000 --output=file:/tmp/abstractsjunk.gz --filter=namespace:NS_MAIN --filter=noredirect --filter=abstract --skip-footer --start=1 --end=1

Fatal error: Class 'NoredirectFilter' not found in /srv/mediawiki/php-1.31.0-wmf.15/maintenance/backup.inc on line 212

Details

Project	Branch	Lines +/-	Subject
operations/mediawiki-config	master	+4 -0	load ActiveAbtract extension explicitly so class autoloading works
mediawiki/extensions/ActiveAbstract	wmf/1.31.0-wmf.15	+4 -4	Revert "Simplify use of --plugin argument of BackupDumper"
mediawiki/extensions/ActiveAbstract	wmf/1.31.0-wmf.15	+105 -111	Revert "Move classes to own files"

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	thcipriani	T180749 1.31.0-wmf.16 deployment blockers
		Resolved		ArielGlenn	T184177 Abstract dumps broken by MW deploy

Event Timeline

ArielGlenn created this task.Jan 4 2018, 1:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2018, 1:17 PM

ArielGlenn triaged this task as High priority.Jan 4 2018, 1:17 PM

https://gerrit.wikimedia.org/r/#/c/398629/ and https://gerrit.wikimedia.org/r/#/c/400397/ I guess are the combo that did it.

ArielGlenn renamed this task from Abstrct dumps broken by MW deploy to Abstract dumps broken by MW deploy.Jan 4 2018, 1:20 PM

ArielGlenn added a project: Dumps-Generation.

Change 402062 had a related patch set uploaded (by Chad; owner: Chad):
[mediawiki/extensions/ActiveAbstract@wmf/1.31.0-wmf.15] Revert "Move classes to own files"

https://gerrit.wikimedia.org/r/402062

Change 402063 had a related patch set uploaded (by Chad; owner: Chad):
[mediawiki/extensions/ActiveAbstract@wmf/1.31.0-wmf.15] Revert "Simplify use of --plugin argument of BackupDumper"

https://gerrit.wikimedia.org/r/402063

demon added a parent task: T180748: 1.31.0-wmf.15 deployment blockers.Jan 4 2018, 3:25 PM

Change 402062 merged by Chad:
[mediawiki/extensions/ActiveAbstract@wmf/1.31.0-wmf.15] Revert "Move classes to own files"

https://gerrit.wikimedia.org/r/402062

Change 402063 merged by Chad:
[mediawiki/extensions/ActiveAbstract@wmf/1.31.0-wmf.15] Revert "Simplify use of --plugin argument of BackupDumper"

https://gerrit.wikimedia.org/r/402063

Mentioned in SAL (#wikimedia-operations) [2018-01-04T15:31:34Z] <demon@tin> Synchronized php-1.31.0-wmf.15/extensions/ActiveAbstract/: unbreak, T184177 (duration: 01m 02s)

Takes care of the immediate issue. Guess we need the long term fix now. Reducing priority to 'normal'.

ArielGlenn lowered the priority of this task from High to Medium.Jan 4 2018, 3:38 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 4 2018, 4:01 PM

In T184177#3875416, @ArielGlenn wrote:

Takes care of the immediate issue. Guess we need the long term fix now. Reducing priority to 'normal'.

Ok I removed this from blocking the train.

ArielGlenn moved this task from Backlog to Blocked/Stalled/Waiting for event on the Dumps-Generation board.Jan 5 2018, 9:34 AM

[4b4bf3ab3e838973feecfa64] [no req]   Error from line 212 of /srv/mediawiki/php-master/maintenance/backup.inc: Class 'NoredirectFilter' not found

Now on my beta snapshot instance, because not fixed yet in master. Blocks T184258.

ArielGlenn mentioned this in T184258: get a snapshot instance running in beta with stretch, php7.Jan 7 2018, 3:05 AM

demon added a parent task: T180250: 1.31.0-wmf.12 deployment blockers.Jan 8 2018, 8:28 PM

demon added a subscriber: Umherirrender.Jan 8 2018, 8:31 PM

I believe there is no autoloader set up for NoredirectFilter class because the extension is not being loaded -- only the individual AbstractFilter.php class was loaded via the --plugin invocation, whereas the autoloader is set up by the extension.json.

In isolation, it seems happier if I add wfLoadExtension('ActiveAbstract') to my LocalSettings.php -- could it be the extension isn't loaded in production either, and was relying on loading the individual plugin files via the invocation config?

Change 403114 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[operations/mediawiki-config@master] load ActiveAbtract extension explicitly so class autoloading works

https://gerrit.wikimedia.org/r/403114

mmodell added a parent task: T180749: 1.31.0-wmf.16 deployment blockers.Jan 9 2018, 8:06 PM

mmodell removed a parent task: T180250: 1.31.0-wmf.12 deployment blockers.Jan 10 2018, 12:29 AM

Change 403114 merged by 20after4:
[operations/mediawiki-config@master] load ActiveAbtract extension explicitly so class autoloading works

https://gerrit.wikimedia.org/r/403114

Still an issue post that ^ merge?

It runs! TYVM.

greg closed this task as Resolved.Jan 13 2018, 7:42 PM

greg assigned this task to ArielGlenn.

ArielGlenn moved this task from Blocked/Stalled/Waiting for event to Done on the Dumps-Generation board.Jan 16 2018, 12:21 PM