Page MenuHomePhabricator

Handle timeout in PaypalEC Orphan Rectifier and enable job
Closed, ResolvedPublic

Event Timeline

Trying to figure out status for records where token has timed out. @Ejegg does it make any sense to add a status for this? Like FinalStatus::TIMEOUT?

Mepps you could also throw a catchable exception on timeout to short-circuit the rest of the calls

@Ejegg there are already is one but it doesn't actually prevent the other calls. Let me know if you want to walk through it later, although as I noted on irc, I'm wondering if I should pause on this until the next sprint.

Change 403742 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] Add timeout status

https://gerrit.wikimedia.org/r/403742

Change 403745 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] WIP: Add catch statement to processDonorReturn, use timeout status

https://gerrit.wikimedia.org/r/403745

Change 403742 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add timeout status

https://gerrit.wikimedia.org/r/403742

Change 404806 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/crm@master] Add logging for errors

https://gerrit.wikimedia.org/r/404806

Change 403745 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add catch statement to processDonorReturn, use timeout status

https://gerrit.wikimedia.org/r/403745

Change 407738 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Update return from timeout

https://gerrit.wikimedia.org/r/407738

Change 407738 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Update return from timeout

https://gerrit.wikimedia.org/r/407738

@Ejegg I think we're ready to enable this? I just ran it on civi1001 and it seemed to be working well.

Change 404806 abandoned by Mepps:
Add logging for errors

https://gerrit.wikimedia.org/r/404806

238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
This comment was removed by Reedy.
Aklapper raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 2:25 PM
Aklapper removed a project: acl*security.
Aklapper added a subscriber: Aklapper.