⚓ T184284 Handle timeout in PaypalEC Orphan Rectifier and enable job

mepps created this task.Jan 5 2018, 3:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2018, 3:52 PM

mepps claimed this task.Jan 5 2018, 4:21 PM

DStrine moved this task from Analysis to Sprint +1 on the Fundraising-Backlog board.Jan 8 2018, 8:45 PM

Trying to figure out status for records where token has timed out. @Ejegg does it make any sense to add a status for this? Like FinalStatus::TIMEOUT?

Mepps you could also throw a catchable exception on timeout to short-circuit the rest of the calls

@Ejegg there are already is one but it doesn't actually prevent the other calls. Let me know if you want to walk through it later, although as I noted on irc, I'm wondering if I should pause on this until the next sprint.

Change 403742 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/SmashPig@master] Add timeout status

https://gerrit.wikimedia.org/r/403742

gerritbot added a project: Patch-For-Review.Jan 11 2018, 8:06 PM

Change 403745 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] WIP: Add catch statement to processDonorReturn, use timeout status

https://gerrit.wikimedia.org/r/403745

Change 403742 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Add timeout status

https://gerrit.wikimedia.org/r/403742

DStrine moved this task from Sprint +1 to Completed in Q3 2017-18 on the Fundraising-Backlog board.Jan 16 2018, 9:02 PM

DStrine added a project: Fundraising Sprint Bermuda Rhombus (where things disappear then reappear).Jan 16 2018, 9:28 PM

Change 404806 had a related patch set uploaded (by Mepps; owner: Mepps):
[wikimedia/fundraising/crm@master] Add logging for errors

https://gerrit.wikimedia.org/r/404806

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Bermuda Rhombus (where things disappear then reappear) board.Jan 19 2018, 10:15 PM

Change 403745 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Add catch statement to processDonorReturn, use timeout status

https://gerrit.wikimedia.org/r/403745

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 22 2018, 7:00 PM

DStrine added a project: Fundraising Sprint Cottage Cheese isn't Made of Cottages.Jan 30 2018, 9:19 PM

mepps moved this task from Backlog to Pending Deployment on the Fundraising Sprint Cottage Cheese isn't Made of Cottages board.Jan 31 2018, 3:23 PM

Change 407738 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Update return from timeout

https://gerrit.wikimedia.org/r/407738

Change 407738 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Update return from timeout

https://gerrit.wikimedia.org/r/407738

DStrine added a project: Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People.Feb 13 2018, 9:26 PM

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People board.Feb 15 2018, 9:56 PM

DStrine added a project: Fundraising Sprint Elevators were never intended to go down.Feb 28 2018, 4:33 PM

@Ejegg I think we're ready to enable this? I just ran it on civi1001 and it seemed to be working well.

Change 404806 abandoned by Mepps:
Add logging for errors

https://gerrit.wikimedia.org/r/404806

mepps closed this task as Resolved.Mar 13 2018, 8:06 PM

• 238482n375 triaged this task as Lowest priority.Jun 15 2018, 8:01 AM

• 238482n375 removed mepps as the assignee of this task.

• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.

• 238482n375 added projects: Analytics-Kanban, Security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.

• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

This comment was removed by Reedy.

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:04 AM

• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

This comment was removed by Reedy.

Reedy removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), Security, Analytics-Kanban, Patch-For-Review.Jun 15 2018, 2:18 PM

Reedy changed the visibility from "Custom Policy" to "Public (No Login Required)".

Reedy added a subscriber: Reedy.

Reedy removed a subscriber: • 238482n375.

Restricted Application added a project: Security. · View Herald TranscriptJun 15 2018, 2:19 PM

Aklapper raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 2:25 PM

Aklapper removed a project: Security.

Aklapper added a subscriber: Aklapper.

Aklapper assigned this task to mepps.Jun 15 2018, 2:37 PM

Handle timeout in PaypalEC Orphan Rectifier and enable job
Closed, ResolvedPublic
Actions

Event Timeline

Handle timeout in PaypalEC Orphan Rectifier and enable jobClosed, ResolvedPublicActions

Event Timeline

Handle timeout in PaypalEC Orphan Rectifier and enable job
Closed, ResolvedPublic
Actions