Page MenuHomePhabricator

Size disparity in caret indicators
Closed, InvalidPublic

Description

The caret indicators with icon overhaul become inharmonious to the text size:

BeforeAfter

It's planned (at some future point) to

  • either get rid of the caret indicators and use 'movement' pack carets
  • or even going further and get rid of indicator as special treatment altogether and rely on 20x20 dp canvas everywhere and leave it up to developer in accordance with designer to special size treatment

Nevertheless, the caret indicators are currently used exclusively in OOUI widget context with the most widely used dropdown down caret.
And with that aligning it to the new guidelines result in inharmonious, jarring looking appearance above.

My proposal is to stay with the current caret indicator as special case, as we are offering a more aligned to principles in 'movement' pack anyways that will also be used in places like MinveraNeue. And when we're going to tackle above options we're going to remove this special case.

Event Timeline

Volker_E created this task.Jan 5 2018, 11:02 PM
Volker_E triaged this task as High priority.

Btw, current usage of 'previous' and 'next' indicators:

Previous
0 occurrences
https://codesearch.wmflabs.org/search/?q=indicator%3A%20%27previous%27&i=nope&files=&repos=

Next
1 occurrence, Extension:SpellingDictionary which doesn't seem to actively developed.
https://codesearch.wmflabs.org/search/?q=indicator%3A%20%27next%27&i=nope&files=&repos=

Volker_E moved this task from Backlog to Next-up on the OOUI board.Jan 8 2018, 9:54 PM

My proposal is to stay with the current caret indicator as special case, as we are offering a more aligned to principles in 'movement' pack anyways that will also be used in places like MinveraNeue. And when we're going to tackle above options we're going to remove this special case.

Given your recent find, do you just want to get rid of it?

@Prtksxna Get rid of what?

As you said in the description:

It's planned (at some future point) to

  • either get rid of the caret indicators and use 'movement' pack carets

I thought we could do that now instead of the future.


Maybe I misunderstood what you said.

And in the end of the task description I put the proposal to “to stay with the current caret indicator as special case”. Basically to put the plan to remove them and only use movement icons on hold due to the insufficient, disruptive application of movement icon as dropdown indicator replacement. No immediate action required here from my POV.
The whole task is meant for transparent documentation.

An additional outcome was to deprecate previous/next indicators in https://gerrit.wikimedia.org/r/#/c/402479/

Volker_E lowered the priority of this task from High to Lowest.Mar 19 2018, 5:42 AM

We gonna wait for T177432 to take place and settle before proceeding here…

Volker_E closed this task as Invalid.Mar 24 2018, 12:00 AM

We've stayed with 'down' indicators due to technical need of being able to provide a icon in a widget like a DropdownWidget, which also features an indicator. We might get rid of indicators in the long-term instead.

238482n375 set Security to Software security bug.Jun 15 2018, 8:04 AM
238482n375 added a project: Security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 added a subscriber: 238482n375.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
Aklapper removed a subscriber: 238482n375.
Restricted Application added a project: Security. · View Herald TranscriptAug 21 2018, 11:15 PM
Volker_E raised the priority of this task from Lowest to Needs Triage.