Page MenuHomePhabricator
Create Task
Maniphest T184333

Query: DROP TEMPORARY TABLE IF EXISTS unittest_imagelinks Error: 1 near "TEMPORARY": syntax error breaking coverage job
Closed, ResolvedPublic
Actions

Description

04:33:00 <!DOCTYPE html><html><head><title>Internal Server Error</title></head><body><h1>Internal Server Error</h1><p>[80253f40ad1886bab61a33d7] [no req]   Wikimedia\Rdbms\DBQueryError from line 1185 of /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? <br />
04:33:00 Query: DROP  TEMPORARY  TABLE IF EXISTS unittest_imagelinks<br />
04:33:00 Function: MediaWikiTestCase::dropMockTables<br />
04:33:00 Error: 1 near &quot;TEMPORARY&quot;: syntax error<br />
04:33:00 <br />
04:33:00 Backtrace:<br />
04:33:00 #0 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/includes/libs/rdbms/database/Database.php(997): Wikimedia\Rdbms\Database-&gt;reportQueryError(string, integer, string, string, boolean)<br />
04:33:00 #1 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/tests/phpunit/MediaWikiTestCase.php(1398): Wikimedia\Rdbms\Database-&gt;query(string, string)<br />
04:33:00 #2 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/tests/phpunit/MediaWikiTestCase.php(1358): MediaWikiTestCase-&gt;dropMockTables(Wikimedia\Rdbms\DatabaseSqlite, array)<br />
04:33:00 #3 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/tests/phpunit/MediaWikiTestCase.php(413): MediaWikiTestCase-&gt;setUpSchema(Wikimedia\Rdbms\DatabaseSqlite)<br />
04:33:00 #4 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): MediaWikiTestCase-&gt;run(PHPUnit_Framework_TestResult)<br />
04:33:00 #5 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite-&gt;run(PHPUnit_Framework_TestResult)<br />
04:33:00 #6 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite-&gt;run(PHPUnit_Framework_TestResult)<br />
04:33:00 #7 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(440): PHPUnit_Framework_TestSuite-&gt;run(PHPUnit_Framework_TestResult)<br />
04:33:00 #8 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/TextUI/Command.php(149): PHPUnit_TextUI_TestRunner-&gt;doRun(PHPUnit_Framework_TestSuite, array)<br />
04:33:00 #9 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/vendor/phpunit/phpunit/src/TextUI/Command.php(100): PHPUnit_TextUI_Command-&gt;run(array, boolean)<br />
04:33:00 #10 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/tests/phpunit/phpunit.php(133): PHPUnit_TextUI_Command::main()<br />
04:33:00 #11 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/maintenance/doMaintenance.php(94): PHPUnitMaintClass-&gt;execute()<br />
04:33:00 #12 /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage/src/tests/phpunit/phpunit.php(172): require(string)<br />
04:33:00 #13 {main}<br />
04:33:00 </p></body></html>

Likely broken by rMW047151c6924d: Introduce DB schema overrides for unit tests..
Full log: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3246/console

Details

SubjectRepoBranchLines +/-
Fix dropping of temp tables on SQLite and PG.mediawiki/coremaster+4 -5
Customize query in gerrit

Related Objects

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Jan 6 2018, 5:06 AM
Legoktm created this task.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes, Aklapper. · View Herald TranscriptJan 6 2018, 5:06 AM
daniel added a comment.Jan 6 2018, 10:08 AM

Hm... is there a way to catch issues with coverage report generation during CI, before merging?...

gerritbot subscribed.Jan 6 2018, 10:24 AM

Change 402573 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Fix dropping of temp tables on SQLite and PG.

https://gerrit.wikimedia.org/r/402573

gerritbot added a project: Patch-For-Review.Jan 6 2018, 10:24 AM
gerritbot added a comment.Jan 6 2018, 11:59 AM

Change 402573 merged by jenkins-bot:
[mediawiki/core@master] Fix dropping of temp tables on SQLite and PG.

https://gerrit.wikimedia.org/r/402573

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 6 2018, 12:01 PM
Umherirrender closed this task as Resolved.Jan 6 2018, 12:46 PM
Umherirrender assigned this task to daniel.
Legoktm added a comment.Jan 6 2018, 6:30 PM

Thanks!

Liuxinyu970226 unsubscribed.Jan 9 2018, 11:25 AM
• 238482n375 removed daniel as the assignee of this task.Jun 15 2018, 8:03 AM
• 238482n375 lowered the priority of this task from Unbreak Now! to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:05 AM
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to daniel.Jun 15 2018, 1:42 PM
Aklapper raised the priority of this task from Lowest to Unbreak Now!.
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 1:42 PM
Aklapper removed a project: acl*security.Jun 15 2018, 1:43 PM
Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL