Page MenuHomePhabricator

Cargo Extension : Add missing PHPdoc to the function
Open, Needs TriagePublic

Description

Some functions in Cargo extension code do not have proper PHPdoc comments.

The task is to provide a patch with PHPdoc for at least 2 functions.

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.

Event Timeline

Fz-29 created this task.Jan 6 2018, 2:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2018, 2:23 PM
Aklapper updated the task description. (Show Details)Jan 7 2018, 12:13 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.

I don't see a good reason to create subtasks here...

Published as https://codein.withgoogle.com/tasks/6502766342045696/

238482n375 set Security to Software security bug.Jun 15 2018, 8:05 AM
238482n375 added a project: Security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 added a subscriber: 238482n375.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
Aklapper removed a subscriber: 238482n375.
Prosper added a subscriber: Prosper.Mar 9 2019, 5:07 AM
Restricted Application added a project: Security. · View Herald TranscriptMar 9 2019, 5:07 AM

I'm trying to submit a patch for this and i keep getting a Gerrit fatal error:

remote: Unauthorized

fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Cargo/'

Do i need to be authorized to push to Cargo?

MaxSem added a subscriber: MaxSem.Mar 9 2019, 5:52 AM

You should use an ssh URL for checking out code instead of https. Run something like git remote set-url gerrit ssh://<your username>@gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo

I ran the command now and still got an error:

fatal: No such remote 'gerrit'

MaxSem added a comment.Mar 9 2019, 6:29 AM

Then replace gerrit in that command with origin.

Change 495439 had a related patch set uploaded (by Prosper Opara; owner: Prosper Opara):
[mediawiki/extensions/Cargo@master] Add PHPDocs to CargoViewData functions

https://gerrit.wikimedia.org/r/495439

Then replace gerrit in that command with origin.

Thanks alot @MaxSem I just saw your follow-up reply, but i was able to change the origin url maually in my .git/config file and it just worked.

The patch has being sent and I'm waiting to get my review

Change 505224 had a related patch set uploaded (by Prosper Opara; owner: Prosper Opara):
[mediawiki/extensions/Cargo@master] Update PHPDocs to CargoViewData functions

https://gerrit.wikimedia.org/r/505224

Change 495439 abandoned by Prosper Opara:
Add PHPDocs to CargoViewData functions

Reason:
I submitted a new patch based on the review here. Some circumstances made me make a new patch instated of continuing on this change-set.

https://gerrit.wikimedia.org/r/495439

Change 505224 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Update PHPDocs to CargoViewData functions

https://gerrit.wikimedia.org/r/505224