Page MenuHomePhabricator

SentryHooks::onLogException sometimes gets passed Error instead of Exception, it should handle this
Closed, ResolvedPublic

Description

On beta, as the dumpsgen user:

dumpsgen@deployment-snapshot01:/srv/deployment/dumps/dumps$ /usr/bin/php7.0 /srv/mediawiki/multiversion/MWScript.php dumpBackup.php --wiki=eswiki --plugin=AbstractFilter:/srv/mediawiki/php-master/extensions/ActiveAbstract/AbstractFilter.php --current --report=1000 --output=file:/mnt/dumpsdata/temp/abstractsjunk.gz  --filter=namespace:NS_MAIN --filter=noredirect --filter=abstract  --start=1 
Fatal error: Uncaught TypeError: Argument 1 passed to SentryHooks::onLogException() must be an instance of Exception, instance of Error given, called in /srv/mediawiki/php-master/includes/Hooks.php on line 177 and defined in /srv/mediawiki/php-master/extensions/Sentry/SentryHooks.php:69
Stack trace:
#0 /srv/mediawiki/php-master/includes/Hooks.php(177): SentryHooks::onLogException(Object(Error), false)
#1 /srv/mediawiki/php-master/includes/Hooks.php(205): Hooks::callHook('LogException', Array, Array, NULL)
#2 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(646): Hooks::run('LogException', Array)
#3 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(111): MWExceptionHandler::logException(Object(Error), 'mwe_handler')
#4 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(148): MWExceptionHandler::rollbackMasterChangesAndLog(Object(Error))
#5 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(121): MWExceptionHandler::handleException(Object(Error))
#6 [int in /srv/mediawiki/php-master/extensions/Sentry/SentryHooks.php on line 69

Event Timeline

ArielGlenn triaged this task as Medium priority.Jan 7 2018, 2:39 AM
ArielGlenn created this task.

Change 402623 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Sentry@master] Be compatible with PHP 7's Throwable interface

https://gerrit.wikimedia.org/r/402623

Change 402623 merged by jenkins-bot:
[mediawiki/extensions/Sentry@master] Be compatible with PHP 7's Throwable interface

https://gerrit.wikimedia.org/r/402623

Legoktm claimed this task.
238482n375 added a project: acl*security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 subscribed.
This comment was removed by Dzahn.
Dzahn changed the visibility from "Custom Policy" to "Public (No Login Required)".
Dzahn removed a subscriber: 238482n375.