Create Task
Maniphest T184466

Live preview doesn’t use new versions of templates embedded in themselves
Open, NormalPublic
Actions

Description

If I edit a template with live preview turned on, and I preview it after some changes, the inclusions of that very template in the preview show the old version.

Steps to reproduce:

  1. Turn on live preview.
  2. Edit a template which is embedded in itself, e.g. hu:Sablon:Yvelines (or edit a template to embed it in itself).
  3. Click on preview.

Expected result:
The embedded instance shows the current (unsaved) version.

Actual result:
The embedded instance shows the latest saved version (which may be even later than the current unsaved version, in case of edit conflict).

Related Objects
Search...

Tacsipacsi created this task.Jan 8 2018, 6:04 PM
Tacsipacsi triaged this task as Normal priority.
matmarex added a comment.Jan 8 2018, 6:12 PM

Hmm, does this work for non-live preview?

Umherirrender added a project: MediaWiki-API.Jan 8 2018, 6:29 PM
Umherirrender added a subscriber: Umherirrender.

Yes, EditPage sets up a fake revision (ParserOptions::setupFakeRevision)

Not sure, if that fits in api's action=parse preview handling and how it affect caching

Anomie added a subscriber: Anomie.Jan 8 2018, 6:38 PM

action=parse doesn't really have a "preview" mode, although it does have a flag to set ParserOptions's IsPreview flag true.

It may be better to file a subtask to request that functionality in ApiParse, leaving this task for having live preview actually use it once it's available.

matmarex removed a subscriber: matmarex.Jan 8 2018, 6:43 PM
• 238482n375 set Security to Software security bug.Jun 15 2018, 8:06 AM
• 238482n375 added a project: Security.
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
• 238482n375 added a subscriber: • 238482n375.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Dzahn removed a project: Security.Jun 15 2018, 10:48 AM
Dzahn changed the visibility from "Custom Policy" to "Public (No Login Required)".
Dzahn removed a subscriber: • 238482n375.
Restricted Application added a project: Security. · View Herald TranscriptJun 15 2018, 10:48 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL