Page MenuHomePhabricator
Create Task
Maniphest T184559

Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

When rolling wmf.16 out onto test wikis this appeared in logstash.

The exception is not user facing, but would likely result in mentions / mention notifications failing.

You can easily reproduce with an edit such as: https://test.wikipedia.org/w/index.php?title=Wikipedia_talk:Foo&oldid=341564

Logstash examples:

[WlUvtQpAMEMAACjJwl8AAADM] /w/api.php   MediaWiki\Storage\RevisionAccessException from line 217 of /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php: Could not determine title for page ID 182836 and revision ID 303638
#0 /srv/mediawiki/php-1.31.0-wmf.16/includes/Storage/RevisionStore.php(1714): MediaWiki\Storage\RevisionStore->getTitle(integer, integer)
#1 /srv/mediawiki/php-1.31.0-wmf.16/includes/Revision.php(926): MediaWiki\Storage\RevisionStore->getPreviousRevision(MediaWiki\Storage\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Echo/includes/DiscussionParser.php(24): Revision->getPrevious()
#3 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Echo/Hooks.php(553): EchoDiscussionParser::generateEventsForRevision(Revision)
#4 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/MWCallableUpdate.php(30): Closure$EchoHooks::onPageContentSaveComplete()
#5 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(259): MWCallableUpdate->doUpdate()
#6 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(210): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#7 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#8 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(900): DeferredUpdates::doUpdates(string)
#9 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(720): MediaWiki->restInPeace(string, boolean)
#10 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#11 {main}

This is similar to T183505 T183550 T183717 T183716 T183548 which appeared to have their underlying issue fixed in https://gerrit.wikimedia.org/r/#/c/400577/

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+189 -18[MCR] RevisionStore::getTitle final logged fallback to master
mediawiki/corewmf/1.31.0-wmf.17+51 -10[MCR] RevisionStore::getTitle final logged fallback to master
mediawiki/corewmf/1.31.0-wmf.16+40 -10[MCR] RevisionStore::getTitle final logged fallback to master
mediawiki/corewmf/1.31.0-wmf.16+20 -10Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""
mediawiki/coremaster+20 -10Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 9 2018, 9:35 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 9 2018, 9:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore triaged this task as Unbreak Now! priority.Jan 9 2018, 9:35 PM
Addshore added a parent task: T180749: 1.31.0-wmf.16 deployment blockers.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptJan 9 2018, 9:36 PM
Addshore updated the task description. (Show Details)Jan 9 2018, 9:36 PM
Addshore updated the task description. (Show Details)
Addshore added projects: Notifications, MediaWiki-General.Jan 9 2018, 9:40 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 9 2018, 9:40 PM
Addshore updated the task description. (Show Details)Jan 9 2018, 9:42 PM
Addshore added a project: Beta-Cluster-reproducible.Jan 10 2018, 8:36 AM
Addshore renamed this task from wmf.16 RevisionAccessException from line 217 of RevisionStore.php: Could not determine title for page ID X and revision ID Y (via EchoDiscussionParser) to RevisionAccessException from line 217 of RevisionStore.php: Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser).Jan 10 2018, 10:11 AM
Addshore renamed this task from RevisionAccessException from line 217 of RevisionStore.php: Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser) to RevisionStore.php: Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser).
Addshore updated the task description. (Show Details)Jan 10 2018, 10:20 AM
Addshore renamed this task from RevisionStore.php: Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser) to Could not determine title for page ID X and revision ID Y (RevisionStore->getPreviousRevision via EchoDiscussionParser).Jan 10 2018, 10:29 AM
gerritbot added a subscriber: gerritbot.Jan 10 2018, 12:33 PM

Change 403391 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

https://gerrit.wikimedia.org/r/403391

gerritbot added a project: Patch-For-Review.Jan 10 2018, 12:33 PM
Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.Jan 10 2018, 12:33 PM
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.
Addshore added a comment.Jan 10 2018, 4:45 PM

Also related and for review: https://gerrit.wikimedia.org/r/#/c/403422/

gerritbot added a comment.Jan 10 2018, 5:14 PM

Change 403391 merged by jenkins-bot:
[mediawiki/core@master] Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

https://gerrit.wikimedia.org/r/403391

gerritbot added a comment.Jan 10 2018, 5:38 PM

Change 403444 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@wmf/1.31.0-wmf.16] Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

https://gerrit.wikimedia.org/r/403444

gerritbot added a comment.Jan 10 2018, 5:43 PM

Change 403446 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@wmf/1.31.0-wmf.16] [MCR] RevisionStore::getTitle final logged fallback to master

https://gerrit.wikimedia.org/r/403446

gerritbot added a comment.Jan 10 2018, 8:27 PM

Change 403444 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.16] Revert "Revert "[MCR] Add and use $title param to RevisionStoregetPrevious/Next""

https://gerrit.wikimedia.org/r/403444

gerritbot added a comment.Jan 10 2018, 8:30 PM

Change 403446 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.16] [MCR] RevisionStore::getTitle final logged fallback to master

https://gerrit.wikimedia.org/r/403446

Addshore closed this task as Resolved.Jan 11 2018, 9:27 AM
Liuxinyu970226 removed a subscriber: Liuxinyu970226.Jan 11 2018, 10:48 AM
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Jan 12 2018, 11:59 AM
gerritbot added a comment.Jan 17 2018, 6:52 PM

Change 404757 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@wmf/1.31.0-wmf.17] [MCR] RevisionStore::getTitle final logged fallback to master

https://gerrit.wikimedia.org/r/404757

gerritbot added a comment.Jan 17 2018, 8:22 PM

Change 404757 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.17] [MCR] RevisionStore::getTitle final logged fallback to master

https://gerrit.wikimedia.org/r/404757

gerritbot added a comment.Feb 6 2018, 11:42 AM

Change 403422 merged by jenkins-bot:
[mediawiki/core@master] [MCR] RevisionStore::getTitle final logged fallback to master

https://gerrit.wikimedia.org/r/403422

CCicalese_WMF moved this task from Next to Done on the Multi-Content-Revisions board.May 10 2018, 4:44 PM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:48 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 5:07 PM
• 238482n375 removed Addshore as the assignee of this task.Jun 15 2018, 8:02 AM
• 238482n375 lowered the priority of this task from Unbreak Now! to Lowest.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper assigned this task to Addshore.Jun 15 2018, 1:42 PM
Aklapper raised the priority of this task from Lowest to Unbreak Now!.
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 1:42 PM
Aklapper removed a project: acl*security.Jun 15 2018, 1:43 PM
Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".
CCicalese_WMF removed a project: Patch-For-Review.Jul 10 2018, 3:34 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 10 2018, 3:34 AM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL