Minerva previews appear with horizontal line due to footer css rule
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jan 9 2018, 9:50 PM

Project Tags

Referenced Files

	F12388720: Screen Shot 2018-01-10 at 9.04.55 AM.png
	Jan 10 2018, 5:06 PM

	F12347261: Screen Shot 2018-01-09 at 1.48.14 PM.png
	Jan 9 2018, 9:50 PM

Subscribers

Description

Visit https://en.wikipedia.org/wiki/SATB?useskin=minerva while logged in with page previews enabled via Beta features (https://en.wikipedia.org/wiki/Special:Preferences)

Note the horizontal line that cuts through the preview here:

Screen Shot 2018-01-09 at 1.48.14 PM.png (366×280 px, 52 KB)

Seems to be caused by a css rule in Minerva for all footer elements. This css rule should be restricted to the skin chrome so it doesn't apply here.

Replication steps

Install Popups and MobileFrontend and Minerva skin
Hover over a link to see a page preview. Note the line above the cog.

Testing

Before and after your change the Minerva footer should look the same

The footer css rule should only impact the Minerva footer.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Remove horizontal line from popups preview in MinervaNeue skin	D3r1ck01	mediawiki/skins/MinervaNeue	master	+6 -2

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jan 9 2018, 9:50 PM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptJan 9 2018, 9:50 PM

xSavitar moved this task from Backlog to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.Jan 10 2018, 9:01 AM

@Jdlrobson Are there any dependencies which will be needed to reproduce this issue locally. This is to avoid that removing the css rule does not affect any other rule :)

Does that help @Eugene233 ^ ?

ovasileva triaged this task as Medium priority.Jan 17 2018, 4:48 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Jan 20 2018, 12:34 AM

Change 406245 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/skins/MinervaNeue@master] Remove horizontal line from popups in MinervaNeue preview

https://gerrit.wikimedia.org/r/406245

gerritbot added a project: Patch-For-Review.Jan 25 2018, 10:27 PM

xSavitar moved this task from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.Jan 25 2018, 10:28 PM

I've quickly submitted a patch for this as it's really annoying. @Jdlrobson, maybe you can have a look?

xSavitar moved this task from Backlog to Doing on the good first task board.Jan 26 2018, 4:21 PM

Moving into sprint so we can track and help review!

Jdlrobson moved this task from Triaged but Future to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Jan 30 2018, 5:44 PM

Jdlrobson set the point value for this task to 2.Jan 30 2018, 5:48 PM

Jdlrobson moved this task from To Do to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Jan 30 2018, 6:05 PM

In T184560#3931241, @Jdlrobson wrote:

Moving into sprint so we can track and help review!

@Jdlrobson, updates done!

Minor issue with the comment, but seems to do the job!

Change 406245 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove horizontal line from popups preview in MinervaNeue skin

https://gerrit.wikimedia.org/r/406245

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jan 30 2018, 7:26 PM

Thanks for the guidance @Jdlrobson. Marking this as resolved :).

xSavitar moved this task from Tasks in progress (Doing) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.Jan 30 2018, 7:37 PM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 30 2018, 8:00 PM

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Is this vandalism?

Aklapper raised the priority of this task from Lowest to Medium.Jun 15 2018, 2:05 PM

Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.

Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.

Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 2:05 PM

Aklapper assigned this task to xSavitar.Jun 15 2018, 2:08 PM

Aklapper removed a project: acl*security.Jun 15 2018, 2:15 PM

Aklapper changed the visibility from "Custom Policy" to "Public (No Login Required)".

Minerva previews appear with horizontal line due to footer css ruleClosed, ResolvedPublic2 Estimated Story PointsActions