Page MenuHomePhabricator

Do not fatal if banner name does not exist - display an error message instead
Closed, DuplicatePublic

Description

I accidentally mistyped a banner name ( wrong: https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/stewvotes good: https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/stewvote) and this is what I got:

[WlU8yQpAEK0AAE12AJUAAABR] 2018-01-09 22:06:01: Fatal exception of type "BannerExistenceException"

I feel CentralNotice should not fatal but display a message like "there's no such banner with that name" or something like that; instead of leaving people with the feeling they broke the wiki ;-)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2018, 10:11 PM
238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM
238482n375 added a project: Security.
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
238482n375 added a subscriber: 238482n375.
This comment was removed by Vgutierrez.
Vgutierrez changed the visibility from "Custom Policy" to "Public (No Login Required)".
Vgutierrez removed subscribers: Vgutierrez, 238482n375.
Vgutierrez added a subscriber: Vgutierrez.
Restricted Application added a project: Security. · View Herald TranscriptJun 15 2018, 10:37 AM