Page MenuHomePhabricator

Nostalgia shows MediaWikiUI button for the special page selector
Closed, ResolvedPublic

Description

Seen on https://nostalgia.wikipedia.org/wiki/Wikipedia_utilities but applies on other pages as well.

The go button for the special page selector is styled to look like an OOUI button. This looks really weird on a website that is supposed to be frozen in time.

The button is styled because $wgUseMediaWikiUIEverywhere is true, which adds the css classes mw-ui-button mw-ui-progressive to the button in [[ https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/Xml.php$459 | Xml::submitButton ]]. Nostalgia calls this function from [[ https://phabricator.wikimedia.org/diffusion/SNOS/browse/master/NostalgiaTemplate.php$356 | NostalgiaTemplate ]].

A quick hack could be that $wgUseMediaWikiUIEverywhere will be set to false, but a better approach would probably be to replace the method call and manually construct the button.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 10 2018, 12:34 PM

Change 403482 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/skins/Nostalgia@master] Don't style the special page selector like an OOUI button

https://gerrit.wikimedia.org/r/403482

Change 403482 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Don't style the special page selector like an OOUI button

https://gerrit.wikimedia.org/r/403482

matmarex closed this task as Resolved.Jan 10 2018, 10:58 PM
matmarex assigned this task to Mainframe98.
matmarex removed a project: Patch-For-Review.
238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM
238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".
This comment was removed by Legoktm.
Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 8:23 AM
Legoktm changed the visibility from "Custom Policy" to "Public (No Login Required)".
Legoktm added a subscriber: Legoktm.