Currently environmetal variables include "2" in them, for example: PYWIKIBOT2_USERNAME, PYWIKIBOT2_NO_USER_CONFIG, PYWIKIBOT2_TEST_WRITE, etc.
This is outdated, as the current version of pywikibot is 3. So number 2 needs to be removed from all environmental variables names (with backwards compatibility), i.e PYWIKIBOT2_USERNAME -> PYWIKIBOT_USERNAME
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
Related Objects
Related Objects
- Mentioned In
- rPWBC315267bcc25b: Update git submodules
Event Timeline
Comment Actions
PYWIKIBOT2_TEST_ are easy. They are only used in our tests. Travis CI configs will be effected. Some forks may be using these in their CI, which will break if they are renamed. I suspect this isnt a big enough problem to worry about. Easy to fix.
The others will need backwards compatibility , especially PYWIKIBOT2_NO_USER_CONFIG , as these variables are how people use Pywikibot as a library.
Comment Actions
Can't we just check the new variable name too, and mark the old one as depreciated, as usual for code functions ?
Comment Actions
Can't we just check the new variable name too, and mark the old one as depreciated, as usual for code functions ?
I think that's exactly what is meant under "backwards compatibility"
Comment Actions
Change 449931 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Rename PYWIKIBOT2_TEST_* environment variables to PYWIKIBOT_TEST_*
Comment Actions
Change 449931 merged by jenkins-bot:
[pywikibot/core@master] Rename PYWIKIBOT2_TEST_* environment variables to PYWIKIBOT_TEST_*
Comment Actions
Still to do:
- PYWIKIBOT2_DIR
- PYWIKIBOT2_DIR_PWB
- PYWIKIBOT2_USER_CONFIG
- PYWIKIBOT2_NO_USER_CONFIG
Comment Actions
Change 450214 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Rename all PYWIKIBOT2_* environment varialbes to PYWIKIBOT_*
Comment Actions
Change 450214 merged by jenkins-bot:
[pywikibot/core@master] Rename all PYWIKIBOT2_* environment variables to PYWIKIBOT_*
Comment Actions
Change 569356 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/i18n@master] [cleanup] rename PYWIKIBOT2_* environment variables to PYWIKIBOT_*
Comment Actions
Change 569356 merged by jenkins-bot:
[pywikibot/i18n@master] [cleanup] rename PYWIKIBOT2_* environment variables to PYWIKIBOT_*
Comment Actions
Change 735668 had a related patch set uploaded (by Xqt; author: Xqt):
[pywikibot/core@master] [cleanup] remove deprecated PYWIKIBOT2 config settings
Comment Actions
Change 735668 merged by jenkins-bot:
[pywikibot/core@master] [cleanup] remove deprecated PYWIKIBOT2 config settings