Page MenuHomePhabricator
Create Task
Maniphest T184775

How do I test my extension's maintenance scripts?
Closed, ResolvedPublic
Actions

Description

This might have an obvious answer, but I've been having trouble running the ORES extension's maintenance classes under PHPUnit. My first pass was nearly working, but it emitted output. I found a MaintenanceTest class under mediawiki-core/tests/phpunit/maintenance, which does the output filtering and so on, but isn't appropriate as a base class because it includes its own tests.

If what I'm looking for doesn't exist, I'd be happy to split the maintenance testing framework from the tests themselves, please let me know.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+259 -446Replace some of MaintenanceTest with dataProviders
mediawiki/coremaster+350 -419Refactor MaintenanceTest to use a base test case
mediawiki/coremaster+143 -137Begin splitting out maintenance test base classes
mediawiki/coremaster+66 -5New namespace MediaWiki\Tests\Maintenance
mediawiki/coremaster+16 -14Minor documentation cleanup
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jan 11 2018, 10:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2018, 10:36 PM
Legoktm added a project: MediaWiki-Core-Tests.Jan 12 2018, 1:21 AM
Legoktm added a subscriber: Legoktm.

If what I'm looking for doesn't exist, I'd be happy to split the maintenance testing framework from the tests themselves, please let me know.

That seems reasonable to me. It would be good to have a base MaintenanceTestCase to ease the process of writing tests for maintenance scripts.

Ladsgroup added a subscriber: Ladsgroup.Jan 12 2018, 10:21 AM

Count me in if you want help,

awight claimed this task.Jan 12 2018, 4:20 PM
awight edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
gerritbot added a subscriber: gerritbot.Jan 16 2018, 4:30 PM

Change 404489 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Minor documentation cleanup

https://gerrit.wikimedia.org/r/404489

gerritbot added a project: Patch-For-Review.Jan 16 2018, 4:30 PM

Change 404490 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] [WIP] New namespace for tests/phpunit/maintenance, begin splitting out maintenance test base classes

https://gerrit.wikimedia.org/r/404490

gerritbot added a comment.Jan 16 2018, 6:22 PM

Change 404512 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] New namespace MediaWiki\Tests\Maintenance

https://gerrit.wikimedia.org/r/404512

gerritbot added a comment.Jan 16 2018, 7:47 PM

Change 404489 merged by jenkins-bot:
[mediawiki/core@master] Minor documentation cleanup

https://gerrit.wikimedia.org/r/404489

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 16 2018, 8:01 PM
gerritbot added a comment.Jan 16 2018, 11:43 PM

Change 404606 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Refactor MaintenanceTest to use a base test case

https://gerrit.wikimedia.org/r/404606

gerritbot added a comment.Jan 17 2018, 10:14 AM

Change 404512 merged by jenkins-bot:
[mediawiki/core@master] New namespace MediaWiki\Tests\Maintenance

https://gerrit.wikimedia.org/r/404512

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 17 2018, 11:00 AM
gerritbot added a comment.Jan 17 2018, 1:34 PM

Change 404665 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Replace some of MaintenanceTest with dataProviders

https://gerrit.wikimedia.org/r/404665

awight moved this task from Backlog to Review on the Machine-Learning-Team (Active Tasks) board.Jan 17 2018, 2:39 PM
gerritbot added a comment.Jan 22 2018, 6:31 AM

Change 404490 merged by jenkins-bot:
[mediawiki/core@master] Begin splitting out maintenance test base classes

https://gerrit.wikimedia.org/r/404490

gerritbot added a comment.Jan 22 2018, 6:34 AM

Change 404606 merged by jenkins-bot:
[mediawiki/core@master] Refactor MaintenanceTest to use a base test case

https://gerrit.wikimedia.org/r/404606

gerritbot added a comment.Jan 22 2018, 6:55 AM

Change 404665 merged by jenkins-bot:
[mediawiki/core@master] Replace some of MaintenanceTest with dataProviders

https://gerrit.wikimedia.org/r/404665

awight moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 23 2018, 5:24 PM
awight closed this task as Resolved.Jan 30 2018, 12:54 AM
Legoktm added a comment.Jan 30 2018, 1:32 AM

@awight could you add some documentation to either https://www.mediawiki.org/wiki/Manual:Writing_maintenance_scripts or https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests ?

awight reopened this task as Open.Jan 30 2018, 1:38 AM

@Legoktm Thanks for the nudge, will do!

awight moved this task from Completed to Backlog on the Machine-Learning-Team (Active Tasks) board.Jan 30 2018, 1:39 AM
awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM
awight added a comment.Jan 31 2018, 11:27 PM

Some docs added:

https://www.mediawiki.org/w/index.php?title=Manual%3AWriting_maintenance_scripts&type=revision&diff=2705223&oldid=2703680

https://www.mediawiki.org/w/index.php?title=Manual%3APHP_unit_testing%2FWriting_unit_tests&type=revision&diff=2705222&oldid=2678449

awight moved this task from Backlog to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 31 2018, 11:27 PM
greg moved this task from INBOX to Watching / External on the Release-Engineering-Team board.Feb 26 2018, 5:31 PM
greg edited projects, added Release-Engineering-Team (Watching / External); removed Release-Engineering-Team.
greg closed this task as Resolved.Mar 3 2018, 1:05 AM
greg added a subscriber: greg.

Per it being in the Done column for scoring team and the docs are there (can we close these as resolved faster, please? :) )

• 238482n375 removed awight as the assignee of this task.Jun 15 2018, 8:04 AM
• 238482n375 triaged this task as Lowest priority.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Aklapper raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 12:43 PM
Aklapper removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Aklapper edited subscribers, added: Aklapper; removed: • 238482n375.
Aklapper assigned this task to awight.Jun 15 2018, 12:47 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL