Page MenuHomePhabricator

Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files)
Open, MediumPublic

Description

tests/phpunit/suite.xml
			<directory suffix=".php">../../maintenance</directory>

That ignores *.inc files (some of which have test coverage!)

Details

Related Gerrit Patches:

Event Timeline

Legoktm created this task.Jan 12 2018, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2018, 1:42 AM

Can we use a regex in suffix? Or do we just add a new line for .inc? Or can we just remove the suffix entirely...?

Krinkle renamed this task from PHPUnit is not reporting test coverage for *.inc maintenance scripts to Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files).Jun 15 2018, 12:54 PM
Krinkle triaged this task as Medium priority.
Krinkle added a project: MediaWiki-General.
Krinkle awarded a token.
Krinkle added a project: good first task.

Change 449925 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925

Change 449925 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925