Page MenuHomePhabricator
Create Task
Maniphest T184782

Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files)
Closed, ResolvedPublic
Actions

Description

tests/phpunit/suite.xml
			<directory suffix=".php">../../maintenance</directory>

That ignores *.inc files (some of which have test coverage!)

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jan 12 2018, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2018, 1:42 AM
Legoktm added a comment.Jan 12 2018, 7:55 PM

Can we use a regex in suffix? Or do we just add a new line for .inc? Or can we just remove the suffix entirely...?

Legoktm added a project: Test-Coverage.Feb 2 2018, 9:01 PM
Krinkle renamed this task from PHPUnit is not reporting test coverage for *.inc maintenance scripts to Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files).Jun 15 2018, 12:54 PM
Krinkle triaged this task as Medium priority.
Krinkle added a project: MediaWiki-General.
Krinkle awarded a token.
Krinkle added a project: good first task.
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jun 15 2018, 12:57 PM
Legoktm mentioned this in T200956: Drop "php5,inc" from MediaWiki-CodeSniffer ruleset of extensions.Aug 2 2018, 2:02 AM
gerritbot subscribed.Aug 2 2018, 5:11 AM

Change 449925 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925

gerritbot added a project: Patch-For-Review.Aug 2 2018, 5:11 AM
gerritbot added a comment.Aug 22 2018, 11:15 AM

Change 449925 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 22 2018, 12:00 PM
Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
Florian added a project: Google-Code-in-2019.Jan 10 2020, 5:38 PM
Florian subscribed.

Sounds like a good task for GCI, I'll mentor this :)

Florian moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board.Jan 10 2020, 5:42 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/5648057396363264/ with 10 task instances for now :)

Ricordisamoa subscribed.Jan 14 2020, 1:01 PM
gerritbot added a comment.Sep 23 2020, 10:59 AM

Change 629346 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] phpcs: Drop exceptions for maintenance/language/checkLanguage.php, deleted

https://gerrit.wikimedia.org/r/629346

gerritbot added a project: Patch-For-Review.Sep 23 2020, 10:59 AM

Change 629347 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] phpcs: Drop exceptions for /maintenance/language/languages.inc, deleted

https://gerrit.wikimedia.org/r/629347

gerritbot added a comment.Sep 23 2020, 10:59 AM

Change 629348 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move CodeCleanerGlobalsPass from .inc to .php

https://gerrit.wikimedia.org/r/629348

gerritbot added a comment.Sep 23 2020, 10:59 AM

Change 629349 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move userDupes from .inc to .php

https://gerrit.wikimedia.org/r/629349

gerritbot added a comment.Sep 23 2020, 10:59 AM

Change 629351 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move sqlite from .inc to .php

https://gerrit.wikimedia.org/r/629351

gerritbot added a comment.Sep 23 2020, 10:59 AM

Change 629352 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move cleanupTable from .inc to .php

https://gerrit.wikimedia.org/r/629352

gerritbot added a comment.Sep 23 2020, 11:00 AM

Change 629353 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move commandLine from .inc to .php

https://gerrit.wikimedia.org/r/629353

gerritbot added a comment.Sep 23 2020, 11:00 AM

Change 629354 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] AutoloadGenerator: Drop support for .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629354

gerritbot added a comment.Sep 23 2020, 11:00 AM

Change 629355 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Doxygen: Stop documenting .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629355

Jdforrester-WMF claimed this task.Sep 23 2020, 11:02 AM
gerritbot added a comment.Sep 23 2020, 3:52 PM

Change 629346 merged by jenkins-bot:
[mediawiki/core@master] phpcs: Drop exceptions for maintenance/language/checkLanguage.php, deleted

https://gerrit.wikimedia.org/r/629346

gerritbot added a comment.Sep 23 2020, 3:52 PM

Change 629347 merged by jenkins-bot:
[mediawiki/core@master] phpcs: Drop exceptions for /maintenance/language/languages.inc, deleted

https://gerrit.wikimedia.org/r/629347

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 4:00 PM
gerritbot added a comment.Sep 25 2020, 12:31 PM

Change 629348 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move CodeCleanerGlobalsPass from .inc to .php

https://gerrit.wikimedia.org/r/629348

gerritbot added a comment.Sep 25 2020, 12:37 PM

Change 629349 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move userDupes from .inc to .php

https://gerrit.wikimedia.org/r/629349

gerritbot added a comment.Sep 25 2020, 5:27 PM

Change 629351 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move sqlite from .inc to .php

https://gerrit.wikimedia.org/r/629351

gerritbot added a comment.Sep 28 2020, 5:29 PM

Change 629353 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move commandLine from .inc to .php

https://gerrit.wikimedia.org/r/629353

gerritbot added a comment.Sep 29 2020, 6:07 AM

Change 629352 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move cleanupTable from .inc to .php

https://gerrit.wikimedia.org/r/629352

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 29 2020, 10:00 AM
gerritbot added a comment.Sep 29 2020, 5:29 PM

Change 629354 merged by jenkins-bot:
[mediawiki/core@master] AutoloadGenerator: Drop support for .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629354

gerritbot added a comment.Sep 29 2020, 5:29 PM

Change 629355 merged by jenkins-bot:
[mediawiki/core@master] Doxygen: Stop documenting .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629355

Jdforrester-WMF closed this task as Resolved.Sep 29 2020, 5:57 PM
gerritbot added a comment.Dec 3 2022, 11:06 AM

Change 863433 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/core@master] phan: Don't analyze .inc files, we don't use them now

https://gerrit.wikimedia.org/r/863433

gerritbot added a comment.Dec 3 2022, 11:17 AM

Change 863434 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/mediawiki-config@master] Update reference to CommandLineInc

https://gerrit.wikimedia.org/r/863434

gerritbot added a comment.Dec 3 2022, 11:21 AM

Change 863435 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/WikimediaMaintenance@master] Rename WikimediaCommandLine.inc to WikimediaCommandLineInc.php

https://gerrit.wikimedia.org/r/863435

gerritbot added a comment.Dec 4 2022, 1:04 PM

Change 863433 merged by jenkins-bot:

[mediawiki/core@master] phan: Don't analyze .inc files, we don't use them now

https://gerrit.wikimedia.org/r/863433

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 4 2022, 2:00 PM
gerritbot added a comment.Dec 15 2022, 9:02 PM

Change 863434 merged by jenkins-bot:

[operations/mediawiki-config@master] Update reference to CommandLineInc

https://gerrit.wikimedia.org/r/863434

Stashbot added a comment.Dec 15 2022, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-15T21:03:07Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:863434|Update reference to CommandLineInc (T184782)]]

Stashbot added a comment.Dec 15 2022, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-15T21:04:49Z] <samtar@deploy1002> samtar and zabe: Backport for [[gerrit:863434|Update reference to CommandLineInc (T184782)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Dec 15 2022, 9:11 PM

Mentioned in SAL (#wikimedia-operations) [2022-12-15T21:11:26Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:863434|Update reference to CommandLineInc (T184782)]] (duration: 08m 18s)

gerritbot added a comment.Dec 19 2022, 5:31 PM

Change 863435 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Rename WikimediaCommandLine.inc to WikimediaCommandLineInc.php

https://gerrit.wikimedia.org/r/863435

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.17; 2023-01-02); removed MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Dec 19 2022, 6:00 PM
CodeReviewBot added a comment.Dec 1 2025, 11:35 AM

hashar opened https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/1049

lint: stop finding '*.inc' files

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits