Page MenuHomePhabricator

Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files)
Closed, ResolvedPublic

Description

tests/phpunit/suite.xml
			<directory suffix=".php">../../maintenance</directory>

That ignores *.inc files (some of which have test coverage!)

Event Timeline

Can we use a regex in suffix? Or do we just add a new line for .inc? Or can we just remove the suffix entirely...?

Krinkle renamed this task from PHPUnit is not reporting test coverage for *.inc maintenance scripts to Get rid of `.inc` files in MediaWiki, using .php instead (was: Test coverage missing for .inc files).Jun 15 2018, 12:54 PM
Krinkle triaged this task as Medium priority.
Krinkle added a project: MediaWiki-General.
Krinkle awarded a token.
Krinkle added a project: good first task.

Change 449925 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925

Change 449925 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move backup.inc to a regular php class file

https://gerrit.wikimedia.org/r/449925

Florian added a subscriber: Florian.

Sounds like a good task for GCI, I'll mentor this :)

Change 629346 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] phpcs: Drop exceptions for maintenance/language/checkLanguage.php, deleted

https://gerrit.wikimedia.org/r/629346

Change 629347 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] phpcs: Drop exceptions for /maintenance/language/languages.inc, deleted

https://gerrit.wikimedia.org/r/629347

Change 629348 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move CodeCleanerGlobalsPass from .inc to .php

https://gerrit.wikimedia.org/r/629348

Change 629349 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move userDupes from .inc to .php

https://gerrit.wikimedia.org/r/629349

Change 629351 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move sqlite from .inc to .php

https://gerrit.wikimedia.org/r/629351

Change 629352 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move cleanupTable from .inc to .php

https://gerrit.wikimedia.org/r/629352

Change 629353 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] maintenance: Move commandLine from .inc to .php

https://gerrit.wikimedia.org/r/629353

Change 629354 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] AutoloadGenerator: Drop support for .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629354

Change 629355 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Doxygen: Stop documenting .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629355

Change 629346 merged by jenkins-bot:
[mediawiki/core@master] phpcs: Drop exceptions for maintenance/language/checkLanguage.php, deleted

https://gerrit.wikimedia.org/r/629346

Change 629347 merged by jenkins-bot:
[mediawiki/core@master] phpcs: Drop exceptions for /maintenance/language/languages.inc, deleted

https://gerrit.wikimedia.org/r/629347

Change 629348 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move CodeCleanerGlobalsPass from .inc to .php

https://gerrit.wikimedia.org/r/629348

Change 629349 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move userDupes from .inc to .php

https://gerrit.wikimedia.org/r/629349

Change 629351 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move sqlite from .inc to .php

https://gerrit.wikimedia.org/r/629351

Change 629353 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move commandLine from .inc to .php

https://gerrit.wikimedia.org/r/629353

Change 629352 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Move cleanupTable from .inc to .php

https://gerrit.wikimedia.org/r/629352

Change 629354 merged by jenkins-bot:
[mediawiki/core@master] AutoloadGenerator: Drop support for .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629354

Change 629355 merged by jenkins-bot:
[mediawiki/core@master] Doxygen: Stop documenting .inc files, we don't use them now

https://gerrit.wikimedia.org/r/629355