Page MenuHomePhabricator
Create Task
Maniphest T184960

There is no license in topic pages of flow discussions
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
pere_prlpz
Jan 15 2018, 11:17 PM
Tags
Referenced Files
F26299127: Screen Shot 2018-10-03 at 5.31.55 PM.png
Oct 4 2018, 12:33 AM
F26299100: Screen Shot 2018-10-03 at 5.25.54 PM.png
Oct 4 2018, 12:33 AM
Subscribers
Aklapper
Catrope
Esanders
Etonkovidova
gerritbot
kostajh
• MZMcBride
View All 11 Subscribers

Description

Every Wikipedia page should have the link to the license of its content in an appropriate place. However, flow pages in the Topic namespace lack a license. For example [[:ca:Tema:U5rfnr0igmb9zhgc]].

Please notice that flow-enabled discussion pages do have a license link, and message edition flow pages also have a license. The issue just affects Topic namespace - that is, pages where you can see just one topic.

Details

SubjectRepoBranchLines +/-
Show copyright on Flow pages with user-generated contentmediawiki/extensions/Flowmaster+13 -0
Show copyright based on $output->hasCopyright()mediawiki/coremaster+38 -8
Revert "Add copyright footer to all pages that need it"mediawiki/extensions/Flowmaster+0 -13
Add copyright footer to all pages that need itmediawiki/extensions/Flowmaster+13 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

pere_prlpz created this task.Jan 15 2018, 11:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2018, 11:17 PM
Reedy added a project: StructuredDiscussions.Jan 15 2018, 11:40 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 15 2018, 11:40 PM
Liuxinyu970226 subscribed.Jan 16 2018, 4:45 AM

GPLv2 or later, isn't that?

Trizek-WMF added a project: WMF-Legal.Jan 16 2018, 9:49 AM
Trizek-WMF added subscribers: Catrope, Trizek-WMF.
In T184960#3901937, @Liuxinyu970226 wrote:

GPLv2 or later, isn't that?

That's the text on MediaWiki:Wikimedia-copyright:

Text is available under the Creative Commons Attribution-ShareAlike License; additional terms may apply. See Terms of Use for details.

@Catrope, this is quite important. Can we solve that soon?

Vriullop subscribed.Jan 16 2018, 10:02 AM
• jmatazzoni moved this task from Untriaged to Old Untriaged on the Collaboration-Team-Triage board.Jan 17 2018, 10:21 PM
gerritbot subscribed.Jan 18 2018, 7:38 PM

Change 405046 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Flow@master] Add copyright footer to all pages that need it

https://gerrit.wikimedia.org/r/405046

gerritbot added a project: Patch-For-Review.Jan 18 2018, 7:38 PM
SBisson assigned this task to Catrope.Jan 18 2018, 8:32 PM
SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
SBisson moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Jan 18 2018, 8:41 PM

Change 405046 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add copyright footer to all pages that need it

https://gerrit.wikimedia.org/r/405046

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 18 2018, 9:00 PM
Etonkovidova subscribed.Jan 20 2018, 1:35 AM

Checked the fix in betalabs - the copyright footer is added to SD board, topic, and post pages.

Etonkovidova closed this task as Resolved.Jan 20 2018, 1:35 AM
Liuxinyu970226 unsubscribed.Jan 22 2018, 2:05 PM
gerritbot added a comment.Feb 1 2018, 8:28 PM

Change 407500 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Revert "Add copyright footer to all pages that need it"

https://gerrit.wikimedia.org/r/407500

gerritbot added a comment.Feb 2 2018, 8:16 AM

Change 407500 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Revert "Add copyright footer to all pages that need it"

https://gerrit.wikimedia.org/r/407500

SBisson reopened this task as Open.Feb 2 2018, 11:21 AM
SBisson moved this task from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
SBisson subscribed.

The patch was reverted.

Esanders subscribed.Feb 2 2018, 8:40 PM
In T186174#3938268, @Esanders wrote:
if ( $out->isArticle() && $title->exists() ) {
    ...
    $tpl->set( 'copyright', $this->getCopyright() );
}

I think we should introduce a new method $out->showsCopyright(), that defaults to isArticle, but is overridden in Flow.

Nemo_bis added a parent task: T87268: Copyright license and attribution issues (tracking).Feb 6 2018, 9:57 PM
• MZMcBride subscribed.Feb 6 2018, 11:12 PM
Catrope edited projects, added Growth-Team; removed Collaboration-Team-Triage (Collab-Team-This-Quarter).Jul 5 2018, 5:56 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 5 2018, 5:56 PM
Catrope moved this task from Inbox to Upcoming Work on the Growth-Team board.Jul 5 2018, 5:56 PM
JTannerWMF moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.Jul 18 2018, 3:11 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 18 2018, 3:14 PM
JTannerWMF moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 1 2018, 5:40 PM
MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)), Collaboration-Team-Triage.Aug 9 2018, 5:48 PM
MMiller_WMF moved this task from Inbox to Needs Discussion on the Growth-Team board.
kostajh moved this task from Needs Discussion to FY 2019-20 on the Growth-Team board.Sep 18 2018, 7:13 PM
kostajh subscribed.

@Trizek-WMF says it's still important, so let's figure it out in Q2.

JTannerWMF moved this task from FY 2019-20 to Sprint 0 (Growth Team) on the Growth-Team board.Sep 26 2018, 6:29 PM
JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
JTannerWMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Oct 3 2018, 1:26 PM

Change 464147 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] Show copyright based on $output->hasCopyright()

https://gerrit.wikimedia.org/r/464147

gerritbot added a comment.Oct 3 2018, 1:26 PM

Change 464148 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Flow@master] Show copyright on Flow pages with user-generated content

https://gerrit.wikimedia.org/r/464148

SBisson claimed this task.Oct 3 2018, 1:26 PM
SBisson moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 3 2018, 5:50 PM
gerritbot added a comment.Oct 3 2018, 6:04 PM

Change 464147 merged by jenkins-bot:
[mediawiki/core@master] Show copyright based on $output->hasCopyright()

https://gerrit.wikimedia.org/r/464147

gerritbot added a comment.Oct 3 2018, 6:07 PM

Change 464148 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Show copyright on Flow pages with user-generated content

https://gerrit.wikimedia.org/r/464148

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 7:00 PM
• Petar.petkovic removed a project: Patch-For-Review.Oct 3 2018, 9:16 PM
Etonkovidova closed this task as Resolved.Oct 4 2018, 12:33 AM

@Trizek-WMF please take a look if everything is in place - the screenshot below is from betalabs and the message displayed is from https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3AWikimedia-copyright (the specific reference was mentioned in your comment).

Screen Shot 2018-10-03 at 5.25.54 PM.png (670×1 px, 163 KB)

vs current production:

Screen Shot 2018-10-03 at 5.31.55 PM.png (671×1 px, 80 KB)

Trizek-WMF added a comment.Oct 4 2018, 1:55 PM

Looks good.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL