Page MenuHomePhabricator

Next and previous buttons overflow outside the image modal when the image is too small
Closed, ResolvedPublic

Description

In image modal in query.wikidata.org, next and previous buttons and the title overflow to the outside of the image modal when the image is to small.

How to reproduce:

  1. Open cats with pictures query: https://goo.gl/6xaWCe
  2. Click on the cat picture that has small resolution.
  3. The title, next, and previous buttons will overflow to the outside of the image modal.

Here's the gif how I did reproduce it: https://imgur.com/a/5R4jd

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I fixed the next and previous button overflow on the image modal. (https://gerrit.wikimedia.org/r/#/c/416227/)
The titles however are too long to be able to fit within the modal and I'm not sure they're really required as the link to the image is given at the footer of all the image cards.
Perhaps the title can be a single word with a Hyperlink, that would solve the issue.

Change 416227 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Prssanna):
[wikidata/query/gui@master] Fixed next and previous buttons overflow on image modal

https://gerrit.wikimedia.org/r/416227

Jonas moved this task from Backlog to Doing on the Wikidata Query UI board.

Change 416328 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/gui-deploy@production] Merging from 40ac9d32989740a6dbad078ee9eb7134472a8414:

https://gerrit.wikimedia.org/r/416328

Change 416328 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from 40ac9d32989740a6dbad078ee9eb7134472a8414:

https://gerrit.wikimedia.org/r/416328