Page MenuHomePhabricator

Re-enabled local preferences not working until second form submission
Closed, ResolvedPublic

Description

When you try to set a local exception to a global preference, the form field is correctly re-enabled when you click the local-exception checkbox, but the new value is not saved.

If you then reselect the desired local preference, and save, it works.

This is because the form field is re-enabled in the front end, but when that form's submitted the field is still disabled (because the list of preferences is built before the new values is saved, and so at that point the local pref has not yet got a local exception).

Event Timeline

Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 16 2018, 7:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 404411 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Don't disable local preferences if a local exception is being saved

https://gerrit.wikimedia.org/r/404411

Change 404411 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Don't disable local preferences if a local exception is being saved

https://gerrit.wikimedia.org/r/404411

MaxSem closed this task as Resolved.Jan 16 2018, 10:06 PM