Page MenuHomePhabricator

Ingenico cc-vmaj form does not have expected order of card types
Closed, ResolvedPublic

Description

I noticed that the Ingenico cc-vmaj form used in the UK, Australia, Spain and others shows cards in the order: Visa, JCB, Mastercard, Amex.

This is not the order suggested by the name or DonationInterfaceFormSettings.php i.e. Visa, Mastercard, Amex, JCB.

The latter order would be better, since it puts the most used cards first (and is what we are doing for card logos in banners).

Details

Related Gerrit Patches:
mediawiki/extensions/DonationInterface : masterSeems inelegant but reorders credit cards

Event Timeline

Pcoombe created this task.Jan 16 2018, 8:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2018, 8:31 PM
mepps claimed this task.Jan 16 2018, 9:18 PM

Change 404802 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Seems inelegant but reorders credit cards

https://gerrit.wikimedia.org/r/404802

Change 404802 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Seems inelegant but reorders credit cards

https://gerrit.wikimedia.org/r/404802

Ejegg closed this task as Resolved.Feb 1 2018, 10:40 PM
Ejegg triaged this task as Medium priority.