Page MenuHomePhabricator

Regression: Lead intro "Found infobox wrapped with container on" warnings are logged on pages with infoboxes inside navboxes
Closed, ResolvedPublic2 Story Points

Description

After T170006, I'm still seeing a lot of events (40k+) relating to infoboxes being logged.

It seems events are logged for pages which have infoboxes inside hidden navboxes e.g.

Expected:

  • Removal of navboxes should happen before attempting to shift the lead paragraph.
  • We should not log infoboxes inside navboxes.

Event Timeline

phuedx added a subscriber: phuedx.

^ Reflecting reality.

ovasileva set the point value for this task to 2.Jan 17 2018, 5:15 PM

Looks like logic is wrong for finding infobox - we also match div > div > table.infobox. We should only match div > table.infobox

Change 404780 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove blacklisted content before applying transforms

https://gerrit.wikimedia.org/r/404780

Change 404810 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.16] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404810

Change 404811 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.17] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404811

Change 404780 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove blacklisted content before applying transforms

https://gerrit.wikimedia.org/r/404780

Change 404810 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.16] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404810

Change 404811 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.17] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404811

Ok this has been SWATTED and the logs are much clearer so am calling this done. It's exposed a bug in T170006 so have moved that back to needs more work...

@Jdlrobson, I will sign this off and the parent per standup.

Niedzielski closed this task as Resolved.Jan 18 2018, 7:12 PM

The occurrences are regular but fewer. We hope that the remaining issues will be resolved by fixing templates soon.

Niedzielski updated the task description. (Show Details)Jan 18 2018, 7:19 PM