Page MenuHomePhabricator
Create Task
Maniphest T185040

Regression: Lead intro "Found infobox wrapped with container on" warnings are logged on pages with infoboxes inside navboxes
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

After T170006, I'm still seeing a lot of events (40k+) relating to infoboxes being logged.

It seems events are logged for pages which have infoboxes inside hidden navboxes e.g.

Expected:

  • Removal of navboxes should happen before attempting to shift the lead paragraph.
  • We should not log infoboxes inside navboxes.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix regressions with updated lead intro transformJdlrobsonmediawiki/extensions/MobileFrontendwmf/1.31.0-wmf.16+8 -3
Fix regressions with updated lead intro transformJdlrobsonmediawiki/extensions/MobileFrontendwmf/1.31.0-wmf.17+8 -3
Remove blacklisted content before applying transformsJdlrobsonmediawiki/extensions/MobileFrontendmaster+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 16 2018, 9:25 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson mentioned this in T170006: MobileFormatter#moveFirstParagraphBeforeInfobox should also move infoboxes wrapped in mw-stack element.
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 16 2018, 9:51 PM
Jdlrobson moved this task from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board-Old board.
• Tbayer unsubscribed.Jan 17 2018, 2:06 AM
phuedx assigned this task to Jdlrobson.Jan 17 2018, 10:35 AM
phuedx subscribed.

^ Reflecting reality.

ovasileva moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.Jan 17 2018, 4:46 PM
ovasileva set the point value for this task to 2.Jan 17 2018, 5:15 PM
ovasileva moved this task from Upcoming to 2017-18 Q2 on the Web-Team-Backlog-Archived board.Jan 17 2018, 5:19 PM
ovasileva moved this task from 2017-18 Q2 to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Jan 17 2018, 6:43 PM
Jdlrobson added a comment.Jan 17 2018, 6:50 PM

Looks like logic is wrong for finding infobox - we also match div > div > table.infobox. We should only match div > table.infobox

gerritbot added a comment.Jan 17 2018, 7:51 PM

Change 404780 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove blacklisted content before applying transforms

https://gerrit.wikimedia.org/r/404780

gerritbot added a project: Patch-For-Review.Jan 17 2018, 7:51 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 7:52 PM
gerritbot added a comment.Jan 17 2018, 9:22 PM

Change 404810 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.16] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404810

gerritbot added a comment.Jan 17 2018, 9:23 PM

Change 404811 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.17] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404811

pmiazga moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 9:56 PM
pmiazga removed a project: Patch-For-Review.
gerritbot added a comment.Jan 17 2018, 10:00 PM

Change 404780 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove blacklisted content before applying transforms

https://gerrit.wikimedia.org/r/404780

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 17 2018, 10:00 PM
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jan 17 2018, 10:27 PM
gerritbot added a comment.Jan 18 2018, 12:17 AM

Change 404810 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.16] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404810

gerritbot added a comment.Jan 18 2018, 12:23 AM

Change 404811 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.31.0-wmf.17] Fix regressions with updated lead intro transform

https://gerrit.wikimedia.org/r/404811

ReleaseTaggerBot edited projects, added: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 18 2018, 1:00 AM
Jdlrobson added a comment.Jan 18 2018, 1:26 AM

Ok this has been SWATTED and the logs are much clearer so am calling this done. It's exposed a bug in T170006 so have moved that back to needs more work...

• Niedzielski claimed this task.Jan 18 2018, 6:08 PM

@Jdlrobson, I will sign this off and the parent per standup.

• Niedzielski closed this task as Resolved.Jan 18 2018, 7:12 PM

The occurrences are regular but fewer. We hope that the remaining issues will be resolved by fixing templates soon.

• Niedzielski updated the task description. (Show Details)Jan 18 2018, 7:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits