Page MenuHomePhabricator

Incorrect syntax highlighting for: "//Text//" AND "//"
Closed, ResolvedPublic3 Estimate Story Points

Description

Steps to reproduce

  1. Enable Wikitext syntax highlighting
  2. Open Wikipedia:Sandbox
  3. Edit it as source
  4. Type //Text// is prefixed by //

Actual results

//Text// and // are highlighted in blue as if they are links.

Expected results

They should not highlighted as they are just rendered as plain text. (See preview)

Screenshot

Details

Related Gerrit Patches:
mediawiki/extensions/CodeMirror : masterDon't match // as protocol unless used in a link

Event Timeline

Kaartic created this task.Jan 17 2018, 5:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 5:23 AM
Kaartic renamed this task from Incorrect syntax highlighting for: //Text// to Incorrect syntax highlighting for: "//Text//" AND "//".Jan 17 2018, 5:27 AM
Kaartic updated the task description. (Show Details)
TBolliger set the point value for this task to 3.

Change 419340 had a related patch set uploaded (by MusikAnimal; owner: MusikAnimal):
[mediawiki/extensions/CodeMirror@master] Don't match // as protocol unless used in a link

https://gerrit.wikimedia.org/r/419340

MusikAnimal moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
MusikAnimal added a subscriber: MusikAnimal.

Pretty confident this won't cause any regressions... but I do hope to get some tests added soon!

Niharika closed this task as Resolved.Mar 15 2018, 11:49 PM
Niharika moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.

Change 419340 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Don't match // as protocol unless used in a link

https://gerrit.wikimedia.org/r/419340