[[Link|Title] breaks link syntax highlighting
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Kaartic
	Jan 17 2018, 5:26 AM

Project Tags

Referenced Files

	F12607669: Screenshot from 2018-01-17 11-14-10.png
	Jan 17 2018, 5:48 AM

	F12607662: Screenshot from 2018-01-17 11-14-00.png
	Jan 17 2018, 5:48 AM

	F12607642: Screenshot from 2018-01-17 10-56-12.png
	Jan 17 2018, 5:26 AM

Subscribers

Description

Steps to reproduce

Enable Wikitext syntax highlighting
Open Wikipedia:Sandbox
Edit it as source
Type

{| class="wikitable" 
! Row 1
! Row 2
|-
| [[WP:NPOV|neutral points]
| [[WP:NOTAFORUM|not a forum]]
|}

Actual results

Screenshot from 2018-01-17 11-14-00.png (342×140 px, 8 KB)

Expected results

The wikitext [[WP:NPOV|neutral points] should be highlighted as an (incomplete) internal link
The wikitext [[WP:NOTAFORUM|not a forum]] should be highlighted as an internal link
The wikitext | [[WP:NOTAFORUM|not a forum]] should be highlighted as a table cell

Screenshot

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CodeMirrorModeMediaWiki: broken link	mediawiki/extensions/CodeMirror	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned In: T259059: Upgrade to CodeMirror 6
T185072: Incorrect syntax highlighting for: [https://example.com

Event Timeline

Kaartic created this task.Jan 17 2018, 5:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 5:26 AM

Kaartic renamed this task from Incorrect syntax highlighting for: //Text// to Incorrect syntax highlighting for: [[link|title].Jan 17 2018, 5:48 AM

Kaartic updated the task description. (Show Details)

Kaartic added a project: MediaWiki-extensions-CodeMirror.

Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 17 2018, 5:49 AM

• TBolliger moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Feb 6 2018, 10:53 PM

Niharika removed a project: Community-Tech.Mar 2 2018, 7:04 AM

TheDJ mentioned this in T185072: Incorrect syntax highlighting for: [https://example.com.Apr 13 2019, 9:55 PM

BEANS-X2 renamed this task from Incorrect syntax highlighting for: [[link|title] to [[Link|Title] breaks link syntax highlighting.May 11 2020, 9:16 AM

Can confirm in Chrome

Bhsd mentioned this in T259059: Upgrade to CodeMirror 6.Dec 13 2023, 9:34 AM

Change #1156259 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorModeMediaWiki: broken link

https://gerrit.wikimedia.org/r/1156259

gerritbot added a project: Patch-For-Review.Jun 12 2025, 8:30 AM

There are several aspects in this example based on my understanding of the PHP parser and the CodeMirror stream parser.

It is natural to assume [[WP:NPOV|neutral points] is a link before the editor closes the bracket, so the corresponding highlighting is appropriate.
The parser parses the table syntax before links, which seems very difficult to represent in a CodeMirror stream parser.
Double brackets ([[) can never appear within a link except for a file link, and this will be fixed in my patch.