Page MenuHomePhabricator

Prepare conftool for safely editing mediawiki-config values
Closed, ResolvedPublic

Description

While conftool is already able to edit and modify values that we would use for mediawiki-config, it has currently no real validation of data we insert this way.

What we need thus is:

  • The ability to read values, even complex ones, edit them in an editor, and safely submit them. This is partly possible using the file interface by reading, saving the output to a file, modifying said file, and then issuing a second command to upload the modified file. It would be better if we were able to automate this process in a way that's more solid than a bash wrapper around the process
  • The ability to validate individual values against some static meta-validation data, and fail with descriptive error messages.
  • The ability to validate individual values against some external program (maybe?)

Event Timeline

Joe triaged this task as Medium priority.Jan 17 2018, 10:01 AM
Joe created this task.
Joe moved this task from Backlog to Doing on the User-Joe board.

Change 405302 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/software/conftool@master] Add preemptive validation.

https://gerrit.wikimedia.org/r/405302

Change 405302 merged by jenkins-bot:
[operations/software/conftool@master] Add preemptive validation.

https://gerrit.wikimedia.org/r/405302

Change 405303 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/software/conftool@master] Refactor conftool.action, add the edit action

https://gerrit.wikimedia.org/r/405303

Change 405303 merged by Giuseppe Lavagetto:
[operations/software/conftool@master] Refactor conftool.action, add the edit action

https://gerrit.wikimedia.org/r/405303

Change 408290 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/software/conftool@master] Safely load yaml files

https://gerrit.wikimedia.org/r/408290

Change 408585 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/software/conftool@master] Add support for jsonschema-based entities

https://gerrit.wikimedia.org/r/408585

Change 408290 merged by jenkins-bot:
[operations/software/conftool@master] Safely load yaml files

https://gerrit.wikimedia.org/r/408290

Change 408585 merged by Giuseppe Lavagetto:
[operations/software/conftool@master] Add support for jsonschema-based entities

https://gerrit.wikimedia.org/r/408585

Change 415046 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] conftool: add json-schemas for MediaWiki variables validation

https://gerrit.wikimedia.org/r/415046

Change 415046 merged by Giuseppe Lavagetto:
[operations/puppet@production] conftool: add json-schemas for MediaWiki variables validation

https://gerrit.wikimedia.org/r/415046