Refactor query parsing logic
Open, MediumPublic
Actions

Assigned To

None

Authored By

	dcausse
	Jan 17 2018, 3:37 PM

Description

Prior to plug a new query parser we should refactor how the search query is parsed and transformed into an elasticsearch query.
Currently there are no strong separation between the parsing logic and the query building logic.
This should ease future development on integrating a new parser.

Note that MediaSearch (through the work done in T252692) is starting to use some of the components built here. There might be consolidation to be made between MediaSearch (WikibaseMediaInfo extension) and CirrusSearch while resuming work on this.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CirrusSearch	master	+148 -51	Add KeywordRegistry

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Invalid		None	T235826 Introduce more complex and updated search syntax to allow power users and tools to do advanced searches
Open		None	T235827 [EPIC] new query parser is used in production
Open	PRODUCTION ERROR	None	T94814 Fix: "Warning: Search backend error during .. took .." (tracking)
Open		None	T185108 Refactor query parsing logic
Resolved		dcausse	T186879 Unify SearchKeywords implementation
Resolved		dcausse	T188530 Externalize the parsing logic from SimpleKeywordFeature and FullTextQueryStringQueryBuilder
Resolved		dcausse	T189880 Introduce SearchQuery
Resolved		dcausse	T197774 Add a way to classify queries
Resolved		dcausse	T198860 Deprecate SearchEngine::replacePrefixes
Resolved		dcausse	T204255 Introduce rewrite/second-try strategies
Resolved		dcausse	T190130 HighlightBuilder: Introduce a way to control the highlighting behaviors
Resolved		dcausse	T228626 Extract interfaces and base classes from SearchResultSet and SearchResult
Resolved		dcausse	T190131 Externalize the phrase suggest builder (DYM)
Open		None	T190132 Introduce keyword interfaces dedicated per usage
Resolved		dcausse	T193392 Deprecate global namespace handling of the prefix keyword (reverted)
Resolved		CommunityTechBot	T194475 Searching by prefix no longer works
Resolved		dcausse	T195305 Add support for boosting keywords
Resolved		dcausse	T195788 Add support for Filtering keyword
Resolved		dcausse	T195815 The prefix keyword should augment and not override the list of requested namespaces
Duplicate		dcausse	T195881 Add a way for keywords to control highlighting
Resolved		dcausse	T191876 Cirrus profile management should provide a standard way to override profile content
Resolved		dcausse	T198318 Change how SpecialSearch/SearchEngine handles the 'prefix' URI param set by the InputBox extension
Resolved		Johan	T198851 CL support to validate a small change in the Special:Search user interface
Open		None	T164589 incategory search does not support OR (union) operator

Event Timeline

dcausse created this task.Jan 17 2018, 3:37 PM

Restricted Application edited projects, added Discovery-ARCHIVED, Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptJan 17 2018, 3:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dcausse claimed this task.Jan 17 2018, 3:37 PM

dcausse triaged this task as Medium priority.

dcausse moved this task from needs triage to Current work on the Discovery-Search board.

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

dcausse updated the task description. (Show Details)

Change 408531 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add KeywordRegistry

https://gerrit.wikimedia.org/r/408531

gerritbot added a project: Patch-For-Review.Feb 6 2018, 1:35 PM

Change 408803 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

Change 408531 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add KeywordRegistry

https://gerrit.wikimedia.org/r/408531

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 8:00 PM

daniel added a subscriber: Physikerwelt.Feb 7 2018, 8:47 PM

dcausse removed a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 8 2018, 1:07 PM

draft of the plan: https://docs.google.com/presentation/d/1XEBN4BgzuuNtU8T9tCJrctHE4WPwxCakFV4wpwnAcOw

dcausse renamed this task from Refactor query parsing logic to EPIC: Refactor query parsing logic.Feb 9 2018, 4:28 PM

dcausse added a project: Epic.

debt closed subtask T186879: Unify SearchKeywords implementation as Resolved.Apr 3 2018, 3:51 PM

TJones mentioned this in T191114: Implement personalized search for logged-in wiki users.Apr 6 2018, 4:05 PM

dcausse added a subtask: T191876: Cirrus profile management should provide a standard way to override profile content.Apr 10 2018, 9:42 AM

debt closed subtask T191876: Cirrus profile management should provide a standard way to override profile content as Resolved.Apr 27 2018, 8:17 PM

dcausse mentioned this in T193392: Deprecate global namespace handling of the prefix keyword (reverted).Apr 30 2018, 12:01 PM

debt closed subtask T188530: Externalize the parsing logic from SimpleKeywordFeature and FullTextQueryStringQueryBuilder as Resolved.May 10 2018, 4:24 PM

dcausse added a subtask: T198318: Change how SpecialSearch/SearchEngine handles the 'prefix' URI param set by the InputBox extension.Jun 27 2018, 11:57 AM

dcausse moved this task from not in use - please delete to Incoming on the Discovery-Search (Current work) board.Jul 12 2018, 1:51 PM

debt closed subtask T198318: Change how SpecialSearch/SearchEngine handles the 'prefix' URI param set by the InputBox extension as Resolved.Jul 31 2018, 5:48 PM

dcausse mentioned this in T94814: Fix: "Warning: Search backend error during .. took .." (tracking).Jul 31 2018, 6:33 PM

dcausse merged a task: T98873: [epic] CirrusSearch: Abandon query_string.Jul 31 2018, 6:50 PM

dcausse added subscribers: • Manybubbles, EBernhardson, • ksmith and 2 others.

dcausse added a parent task: T94814: Fix: "Warning: Search backend error during .. took .." (tracking).Jul 31 2018, 6:54 PM

Smalyshev mentioned this in T200995: Improve constraint property item suggestions for property constraint values (value type).Aug 2 2018, 6:41 PM

debt closed subtask T189880: Introduce SearchQuery as Resolved.Nov 9 2018, 4:42 PM

dcausse removed a project: Patch-For-Review.Nov 27 2018, 6:27 PM

TJones closed subtask T190131: Externalize the phrase suggest builder (DYM) as Resolved.Jan 29 2019, 6:54 PM

TJones edited projects, added Discovery-Search; removed Discovery-Search (Current work).Jan 29 2019, 10:03 PM

TJones moved this task from needs triage to [epic] on the Discovery-Search board.

Gehel closed subtask T190130: HighlightBuilder: Introduce a way to control the highlighting behaviors as Resolved.Oct 1 2019, 5:31 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)