Page MenuHomePhabricator

Refactor query parsing logic
Open, MediumPublic

Description

Prior to plug a new query parser we should refactor how the search query is parsed and transformed into an elasticsearch query.
Currently there are no strong separation between the parsing logic and the query building logic.
This should ease future development on integrating a new parser.

Note that MediaSearch (through the work done in T252692) is starting to use some of the components built here. There might be consolidation to be made between MediaSearch (WikibaseMediaInfo extension) and CirrusSearch while resuming work on this.

Related Objects

StatusSubtypeAssignedTask
InvalidNone
OpenNone
OpenPRODUCTION ERRORNone
OpenNone
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
Resolveddcausse
OpenNone
Resolveddcausse
ResolvedCommunityTechBot
Resolveddcausse
Resolveddcausse
Resolveddcausse
Duplicatedcausse
Resolveddcausse
Resolveddcausse
ResolvedJohan

Event Timeline

dcausse created this task.Jan 17 2018, 3:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse claimed this task.Jan 17 2018, 3:37 PM
dcausse triaged this task as Medium priority.
dcausse moved this task from needs triage to Current work on the Discovery-Search board.
dcausse updated the task description. (Show Details)

Change 408531 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add KeywordRegistry

https://gerrit.wikimedia.org/r/408531

Change 408803 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

Change 408531 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add KeywordRegistry

https://gerrit.wikimedia.org/r/408531

dcausse renamed this task from Refactor query parsing logic to EPIC: Refactor query parsing logic.Feb 9 2018, 4:28 PM
dcausse added a project: Epic.
TJones moved this task from needs triage to [epic] on the Discovery-Search board.
Aklapper removed dcausse as the assignee of this task.Jun 19 2020, 4:19 PM

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

CBogen renamed this task from EPIC: Refactor query parsing logic to Refactor query parsing logic.Sep 2 2020, 2:02 PM
CBogen removed a project: Epic.
CBogen moved this task from [epic] to elastic / cirrus on the Discovery-Search board.
dcausse updated the task description. (Show Details)Thu, Nov 26, 7:44 AM