Page MenuHomePhabricator
Create Task
Maniphest T185115

PHPUnit runner does not load required dependencies from composer.json (SendGrid extension)
Closed, ResolvedPublic
Actions

Description

While working on PHPUnit tests for SendGrid extension (see T183572 and https://gerrit.wikimedia.org/r/#/c/404400), it was noticed that phpunit test runner does not load required dependencies specified in composer.json.

I tried looking for similar cases in other extensions tests, but couldn't find anything similar.

It was mentioned by @Addshore on IRC that

The zuul / Jenkins config / job probably needs to be changed to one that does the composer stuff :)

Any tips for best practices for such cases?

Details

SubjectRepoBranchLines +/-
Use extension-unittests-composer-non-voting for SendGrid extension testingintegration/configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

nikitavbv created this task.Jan 17 2018, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 4:57 PM
nikitavbv added a project: MediaWiki-extensions-SendGrid.Jan 17 2018, 4:58 PM
WMDE-Fisch subscribed.Jan 17 2018, 4:59 PM
Reedy added a project: Continuous-Integration-Config.Jan 17 2018, 5:01 PM
Umherirrender added subscribers: hashar, Umherirrender.Jan 17 2018, 5:26 PM

Change from extension-unittests-generic to extension-unittests-composer in test config (layout.yaml) to test against the extensions own composer dependency. But I have no idea, if there is a php 5.6 unittest job to do the work in this case. The current tests running 5.5.9

For WMF deployed extensions (or extensions in preparation for wmf deloyment), the dependency must be added to mediawiki/vendor after code/security review of the package to ensure that it will be installed on the cluster.

gerritbot subscribed.Jan 17 2018, 6:14 PM

Change 404748 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[integration/config@master] Use extension-unittests-composer for SendGrid extension testing

https://gerrit.wikimedia.org/r/404748

gerritbot added a project: Patch-For-Review.Jan 17 2018, 6:14 PM
nikitavbv added a comment.Jan 17 2018, 6:15 PM

Change from extension-unittests-generic to extension-unittests-composer in test config (layout.yaml) to test against the extensions own composer dependency.

Thank you, @Umherirrender! Hope that solves the problem. I have just uploaded a patch regarding this: https://gerrit.wikimedia.org/r/404748

xSavitar moved this task from Backlog to Doing (On-Going) on the MediaWiki-extensions-SendGrid board.Jan 18 2018, 7:22 AM
Addshore awarded a token.Jan 19 2018, 9:04 AM
xSavitar assigned this task to nikitavbv.Jan 20 2018, 12:41 PM
xSavitar awarded a token.

As you are working on this :)

gerritbot added a comment.Jan 31 2018, 5:29 AM

Change 404748 merged by jenkins-bot:
[integration/config@master] Use extension-unittests-composer-non-voting for SendGrid extension testing

https://gerrit.wikimedia.org/r/404748

xSavitar closed this task as Resolved.Jan 31 2018, 6:18 AM
nikitavbv moved this task from Doing (On-Going) to Completed (Done) on the MediaWiki-extensions-SendGrid board.Jan 31 2018, 9:47 AM

This fixed the issue! Thanks everyone for your help! Can we use extension-unittests-composer instead of extension-unittests-composer-non-voting now, if it works good?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL