Page MenuHomePhabricator

Deprecate and remove 'alert' indicator
Closed, ResolvedPublic

Description

On searching through further icon/indicator usages, I've identified that 'alert' indicator seems to be only used in two places:

  • As code example in IndicatorWidget.js
  • In Flow's MentionInspector where it actually should be an icon and not an indicator


(Current UI)

As we want to keep duplication of icons in our library low and also reduce the number of indicators to only the most important special cases, we should:

Event Timeline

Volker_E created this task.

Change 404884 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag indicator 'alert'as to be removed

https://gerrit.wikimedia.org/r/404884

Change 404885 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] Replace 'alert' indicator as it's deprecated

https://gerrit.wikimedia.org/r/404885

Change 404884 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] icons: Flag indicator 'alert' as to be removed

https://gerrit.wikimedia.org/r/404884

Change 405045 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2

https://gerrit.wikimedia.org/r/405045

Change 404885 merged by jenkins-bot:
[oojs/ui@master] demos, docs: Replace 'alert' indicator, as it's deprecated

https://gerrit.wikimedia.org/r/404885

Change 405204 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Flow@master] Replace deprecated 'alert' indicator with similar icon

https://gerrit.wikimedia.org/r/405204

Change 405204 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated 'alert' indicator with similar icon

https://gerrit.wikimedia.org/r/405204

Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)

Change 405045 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] indicators: Remove 'alert', deprecated in v0.25.2

https://gerrit.wikimedia.org/r/405045

Volker_E raised the priority of this task from High to Needs Triage.Jun 1 2018, 2:07 PM
Volker_E moved this task from Doing… to Done on the UI-Standardization-Kanban board.

We missed a use in VE's template dialog, where it is used to indicate deprecated params.