Page MenuHomePhabricator

Add PHP_CodeSniffer for codestyle checks to SendGrid extension
Closed, ResolvedPublic

Description

While working on T183572 I have noticed, that CI job lacks codestyle checks and PHP_CodeSniffer scripts are not present in composer.json of SendGrid extension.

I think it is important to add this to ensure that code of this extension remains clean.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 11:06 PM

I will add this!

Change 404880 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/extensions/SendGrid@master] Add PHP_CodeSniffer for codestyle checks to SendGrid extension

https://gerrit.wikimedia.org/r/404880

Umherirrender closed this task as Resolved.Jan 18 2018, 6:54 PM
Umherirrender triaged this task as Normal priority.

Change 404880 merged by Umherirrender:
[mediawiki/extensions/SendGrid@master] Add PHP_CodeSniffer for codestyle checks to SendGrid extension

https://gerrit.wikimedia.org/r/404880

Thanks for working on this @Phantom42. I'll so try to look into the issue of the PHP version that Jenkins is complaining about. Thanks.