Page MenuHomePhabricator
Create Task
Maniphest T185159

Add PHP_CodeSniffer for codestyle checks to SendGrid extension
Closed, ResolvedPublic
Actions

Description

While working on T183572 I have noticed, that CI job lacks codestyle checks and PHP_CodeSniffer scripts are not present in composer.json of SendGrid extension.

I think it is important to add this to ensure that code of this extension remains clean.

Details

SubjectRepoBranchLines +/-
Add PHP_CodeSniffer for codestyle checks to SendGrid extensionmediawiki/extensions/SendGridmaster+15 -2
Customize query in gerrit

Related Objects

Event Timeline

nikitavbv created this task.Jan 17 2018, 11:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 17 2018, 11:06 PM
nikitavbv claimed this task.Jan 17 2018, 11:06 PM

I will add this!

gerritbot subscribed.Jan 17 2018, 11:20 PM

Change 404880 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/extensions/SendGrid@master] Add PHP_CodeSniffer for codestyle checks to SendGrid extension

https://gerrit.wikimedia.org/r/404880

gerritbot added a project: Patch-For-Review.Jan 17 2018, 11:20 PM
nikitavbv mentioned this in rESNGb6c30731468a: Add PHP_CodeSniffer for codestyle checks to SendGrid extension.Jan 17 2018, 11:24 PM
nikitavbv mentioned this in rESNG7aa9a14a9bf9: Add PHP_CodeSniffer for codestyle checks to SendGrid extension.Jan 18 2018, 12:15 AM
nikitavbv mentioned this in rESNG67af7881b584: Add PHP_CodeSniffer for codestyle checks to SendGrid extension.Jan 18 2018, 5:47 AM
xSavitar moved this task from Backlog to Doing (On-Going) on the MediaWiki-extensions-SendGrid board.Jan 18 2018, 7:22 AM
xSavitar awarded a token.Jan 18 2018, 12:03 PM
Umherirrender closed this task as Resolved.Jan 18 2018, 6:54 PM
Umherirrender triaged this task as Medium priority.
gerritbot added a comment.Jan 18 2018, 7:01 PM

Change 404880 merged by Umherirrender:
[mediawiki/extensions/SendGrid@master] Add PHP_CodeSniffer for codestyle checks to SendGrid extension

https://gerrit.wikimedia.org/r/404880

xSavitar moved this task from Doing (On-Going) to Completed (Done) on the MediaWiki-extensions-SendGrid board.Jan 18 2018, 7:10 PM

Thanks for working on this @Phantom42. I'll so try to look into the issue of the PHP version that Jenkins is complaining about. Thanks.

nikitavbv mentioned this in rESNGeaba95381453: Final NoteDb migration updates.Jun 11 2018, 8:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL