broken favicon/icon links in 2017 report
Closed, ResolvedPublic

Description

It seems that favicon and icon links in the 2017 report are broken.

There are links to paths starting with /images , not a relative path ./images.

~/annualreport/2017$ grep -r "href=\"/" *
community.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
community.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
community.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
community.html:    <link rel="manifest" href="/images/icons/manifest.json">
community.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
community.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
donors.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
donors.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
donors.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
donors.html:    <link rel="manifest" href="/images/icons/manifest.json">
donors.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
donors.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
financials.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
financials.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
financials.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
financials.html:    <link rel="manifest" href="/images/icons/manifest.json">
financials.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
financials.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
index.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
index.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
index.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
index.html:    <link rel="manifest" href="/images/icons/manifest.json">
index.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
index.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
leadership.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
leadership.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
leadership.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
leadership.html:    <link rel="manifest" href="/images/icons/manifest.json">
leadership.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
leadership.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
stories.html:    <link rel="apple-touch-icon" sizes="180x180" href="/images/icons/apple-touch-icon.png">
stories.html:    <link rel="icon" type="image/png" sizes="32x32" href="/images/icons/favicon-32x32.png">
stories.html:    <link rel="icon" type="image/png" sizes="16x16" href="/images/icons/favicon-16x16.png">
stories.html:    <link rel="manifest" href="/images/icons/manifest.json">
stories.html:    <link rel="mask-icon" href="/images/icons/safari-pinned-tab.svg" color="#333333">
stories.html:    <link rel="shortcut icon" href="/images/icons/favicon.ico">
Dzahn created this task.Jan 17 2018, 11:50 PM
Dzahn triaged this task as High priority.
Dzahn removed Dzahn as the assignee of this task.
Reedy updated the task description. (Show Details)Jan 18 2018, 12:14 AM

Change 404891 had a related patch set uploaded (by Reedy; owner: Reedy):
[wikimedia/annualreport@master] Make images relative not absolute

https://gerrit.wikimedia.org/r/404891

Change 404891 merged by Dzahn:
[wikimedia/annualreport@master] Make images relative not absolute

https://gerrit.wikimedia.org/r/404891

Reedy closed this task as Resolved.Jan 18 2018, 12:36 AM
Reedy removed a project: Patch-For-Review.
Reedy claimed this task.

Fine bar caching issues